Skip to content

Add partial flush support to SFLUSH command #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tezc merged 2 commits into from
Jul 3, 2025
Merged

Add partial flush support to SFLUSH command #42

tezc merged 2 commits into from
Jul 3, 2025

Conversation

@tezc
Copy link
Owner

@tezc tezc commented Jul 3, 2025 •
edited
Loading

  • Add partial flush support to SFLUSH command: Currently, flush operation is not efficient. It iterates the keys to call KSN function etc. We can cleanup whole slots dict more efficiently in the BIO thread. We should revisit this and improve the performance in future once we decide how to handle this case.
  • Minor fix for printing replica port number in logs.

@tezc tezc requested a review from ShooterIT July 3, 2025 07:27
@tezc tezc marked this pull request as ready for review July 3, 2025 07:27
ShooterIT
ShooterIT approved these changes Jul 3, 2025
View reviewed changes
@tezc tezc merged commit 3764612 into cluster-asm Jul 3, 2025
39 of 40 checks passed
@tezc tezc deleted the cluster-asm-sflush branch July 3, 2025 16:04
tezc added a commit that referenced this pull request Sep 10, 2025
@tezc
Add partial flush support to SFLUSH command (#42)
1ff6c89 
Add partial flush support to SFLUSH command
tezc added a commit that referenced this pull request Sep 16, 2025
@tezc
Add partial flush support to SFLUSH command (#42)
ffcf9fb 
Add partial flush support to SFLUSH command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShooterIT ShooterIT ShooterIT approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tezc @ShooterIT