Add basic filtered replication and write pause #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShooterIT
reviewed
Jun 30, 2025
| /* Add main channel client to the list of slaves */ | ||
| client *main_ch_client = task->main_channel_client; | ||
| main_ch_client->flags |= CLIENT_SLAVE; | ||
| main_ch_client->flags |= (CLIENT_SLAVE | CLIENT_REPL_MIGRATION_DEST); |
Collaborator
There was a problem hiding this comment.
for your approach, maybe we don't mark this client as slave, so can revert my several changes, let me try it later
Owner
Author
There was a problem hiding this comment.
yes, I initially did it that way. Either approach is possible but not sure which one is better. In one sense, this is a slave and makes sense to mark as SLAVE. Though, it causes some problems when you don't want to forward from replication backlog directly and had to mitigate this way.
Collaborator
There was a problem hiding this comment.
OK, i see, we can decide later
ShooterIT
reviewed
Jun 30, 2025
ShooterIT
approved these changes
Jun 30, 2025
tezc
added a commit
that referenced
this pull request
Sep 10, 2025
Add basic filtered replication and write pause Changes: Initial implementation for filtered repl stream delivery to destination node Initial write pause Fixes for crashes & code refactor TODO: Write pause time limit Tests
tezc
added a commit
that referenced
this pull request
Sep 16, 2025
Add basic filtered replication and write pause Changes: Initial implementation for filtered repl stream delivery to destination node Initial write pause Fixes for crashes & code refactor TODO: Write pause time limit Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
TODO: