Refactor to use slot range array #35
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did refactor a few things.
struct slotRangeArrayinstead oflist *slot_ranges. For plugin API, I see that we need to work with primitive types as the current plugin will be in rust, it is harder to uselistlike complex structs there.struct slotRangeArrayis easier to translate to other languages. Also, I seelist *slot_rangesdoes not have much benefit over an array of slot ranges.struct slotRangeand usedstart_slot/end_slotinstead offirst/last.sflush,cluster importandcluster syncslots