Skip to content

Conversation

@tezc
Copy link
Owner

@tezc tezc commented Jun 16, 2025

I did refactor a few things.

  • First used struct slotRangeArray instead of list *slot_ranges. For plugin API, I see that we need to work with primitive types as the current plugin will be in rust, it is harder to use list like complex structs there. struct slotRangeArray is easier to translate to other languages. Also, I see list *slot_ranges does not have much benefit over an array of slot ranges.
  • To prevent terminology mixup, I refactored struct slotRange and used start_slot/end_slot instead of first/last.
  • Tried to reuse parser code for sflush, cluster import and cluster syncslots

@tezc tezc requested a review from ShooterIT June 16, 2025 04:01
@ShooterIT ShooterIT self-assigned this Jun 16, 2025
@tezc tezc merged commit b62dd59 into cluster-asm Jun 16, 2025
14 of 30 checks passed
@tezc tezc deleted the cluster-refactor branch June 16, 2025 11:36
tezc added a commit that referenced this pull request Sep 10, 2025
refactor to use slot range array
tezc added a commit that referenced this pull request Sep 16, 2025
refactor to use slot range array
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants