Dummy implementation of CLUSTER MIGRATION #29
Conversation
| unsigned char owner_not_claiming_slot[CLUSTER_SLOTS / 8]; | ||
|
|
||
| /* Atomic slot migration */ | ||
| list *asm_links; |
There was a problem hiding this comment.
will a dest node be imported concurrently multiple slot ranges from different source nodes?
There was a problem hiding this comment.
yes, there might be multiple ongoing operations.
There was a problem hiding this comment.
OK, if so, it may be much complicated
There was a problem hiding this comment.
initially, we can allow single migration operation but we should keep that in mind, it can be multiple parallel operations in future.
There was a problem hiding this comment.
btw I'm thinking that this list will be there on source side as well, so we can run CLUSTER MIGRATION STATUS. IT is just a single list holds both importing and migrating operations on either side.
src/cluster_asm.c
Outdated
| #define ASM_IMPORT (1 << 1) | ||
| #define ASM_MIGRATE (1 << 2) | ||
|
|
||
| typedef struct asmLink { |
There was a problem hiding this comment.
why do we call it asmLink, it seems a slot-ranges migration task, right?
There was a problem hiding this comment.
you don't like the name? cluster_legacy.c uses "link" for the connection. I just added asm prefix similar to it. Do you prefer a better name?
There was a problem hiding this comment.
I think the connection just is a part of migration task, how about asmTask
makes sense to me |
Dummy implementation of CLUSTER MIGRATION
Dummy implementation of CLUSTER MIGRATION
Dummy implementation for these commands:
CLUSTER MIGRATION IMPORT start-slot end-slot [start-slot end-slot ...]CLUSTER MIGRATION STATUSCLUSTER MIGRATION CANCEL start-slot end-slot [start-slot end-slot ...]The implementation primarily handles command parsing. Import requests are simply queued without triggering any action.
@ShooterIT this is a quick implementation to get an idea about the API. Let's see if we are comfortable with this.
Please notice that CANCEL may cancel multiple operations and the reply is number of cancelled operation. I feel like this makes more sense. Let me know what you think.