Merged
Conversation
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
sanderpick
reviewed
Dec 1, 2020
Comment on lines
+23
to
44
| // @todo: Clean up tag numbers with next major release | ||
| message NewDBRequest { | ||
| bytes dbID = 1; | ||
| repeated CollectionConfig collections = 2; | ||
| string name = 3; | ||
| bool block = 5; | ||
| bytes threadKey = 6; | ||
| bytes key = 6; | ||
| bytes logKey = 7; | ||
| string name = 3; | ||
| repeated CollectionConfig collections = 2; | ||
|
|
||
| bool block = 5 [deprecated = true]; | ||
| } | ||
|
|
||
| // @todo: Clean up tag numbers with next major release | ||
| message NewDBFromAddrRequest { | ||
| bytes addr = 1; | ||
| bytes key = 2; | ||
| repeated CollectionConfig collections = 3; | ||
| bytes logKey = 7; | ||
| string name = 4; | ||
| repeated CollectionConfig collections = 3; | ||
| bool block = 5; | ||
| bytes threadKey = 6; | ||
| bytes logKey = 7; | ||
|
|
||
| bytes threadKey = 6 [deprecated = true]; | ||
| } |
Contributor
There was a problem hiding this comment.
Somehow I missed this in Daniel's PR. threadKey was added, but we already have key. This change does not modify the proto tag numbers. We can clean this up on the next major release.
sanderpick
reviewed
Dec 1, 2020
| db.WithNewManagedName(req.Name), | ||
| db.WithNewManagedCollections(collections...), | ||
| db.WithNewManagedToken(token), | ||
| db.WithNewManagedBackfillBlock(req.Block), |
Contributor
There was a problem hiding this comment.
This has no meaning in the context of NewDB
sanderpick
reviewed
Dec 1, 2020
| return nil, err | ||
| } | ||
| if args.Key.Defined() && !args.Key.CanRead() { | ||
| return nil, ErrThreadReadKeyRequired |
Contributor
There was a problem hiding this comment.
Early out if thread key does not contain a read component.
sanderpick
approved these changes
Dec 1, 2020
Signed-off-by: Sander Pick <sanderpick@gmail.com>
5654eb3 to
a44bcef
Compare
|
FYI, this changed the public API: |
jtacoma
added a commit
to google/note-maps
that referenced
this pull request
Dec 8, 2020
Contributor
|
Doh, thanks for the heads up @jtacoma - I'll make a not on the release that includes those changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.