Merged
Conversation
sanderpick
approved these changes
Oct 14, 2020
Contributor
sanderpick
left a comment
There was a problem hiding this comment.
LGTM! One question regarding protocol change procedure.
| lid, | ||
| map[peer.ID]cid.Cid{lid: cid.Undef}, | ||
| MaxPullLimit) | ||
| // TODO after protocol change request only new log |
Contributor
There was a problem hiding this comment.
So, are you wanting to follow this up with a protocol change ASAP?
Contributor
Author
There was a problem hiding this comment.
Well, as we previously discussed it, protocol change requires getting rid of record integrity check, and you've suggested that the next version of threads protocol should be issued. It'd be great, but not urgent now, as current PR already significantly reduces number of irrelevant records returned by the GetRecords request.
Contributor
There was a problem hiding this comment.
Okay, SGTM. I have some other changes that will be nice to get in before a protocol change. So, will be nice to wait for those.
| } | ||
|
|
||
| // return reconstructed sequence and success flag | ||
| func (s *recordSequence) List() ([]linkedRecord, bool) { |
Signed-off-by: Anton Dort-Golts <dortgolts@gmail.com>
Signed-off-by: Anton Dort-Golts <dortgolts@gmail.com>
Signed-off-by: Anton Dort-Golts <dortgolts@gmail.com>
Signed-off-by: Anton Dort-Golts <dortgolts@gmail.com>
65ad995 to
ed9c71b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #433
Do not request already known records for all logs contained in a thread on receiving a
PushLogmessage.It should help to reduce traffic and resources of both nodes and replicators.