Skip to content

GetRecords response with all logs in the thread #433

@dgtony

Description

@dgtony

Core API method GetRecords is currently used in two cases:

  • Pulling the thread. Here we expect receiving information about all the logs including ones we are not aware of yet.
  • Node receives PushLog request, containing updated information about some specific log. After that recipient starts pulling specified log from the sender (btw why always pull log from the beginning?), but currently it will receive entire thread information including records for all the logs of the thread in response.

Looks like there is some redundancy, and network traffic and resource consumption can be optimized here. For example, we can add special flag allLogs in protobuf message GetRecordsRequest and implement it on the server. Method server.GetRecords by default should return only log IDs explicitly specified in the request and setting the flag allLogs = true enables current behaviour, when server returns all known logs associated with the given thread ID.

@sanderpick what do you think about such a modification?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions