adjust vitest ambient declaration file according to vitest docs#612
Merged
gnapse merged 2 commits intotesting-library:mainfrom Jul 24, 2024
Merged
adjust vitest ambient declaration file according to vitest docs#612gnapse merged 2 commits intotesting-library:mainfrom
gnapse merged 2 commits intotesting-library:mainfrom
Conversation
gnapse
approved these changes
Jul 24, 2024
Member
|
@all-contributors please add @vorant94 for code |
Contributor
|
I've put up a pull request to add @vorant94! 🎉 |
|
🎉 This PR is included in version 6.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 tasks
vorant94
added a commit
to vorant94/jest-dom
that referenced
this pull request
Sep 12, 2024
…cs (testing-library#612)" This reverts commit 06d19ba.
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Changed the way of patching
vitesttypes withjest-domcustom matchersWhy:
The current approach uses
@vitest/expectmodule, which is considered to be internal implementation details by thevitestteam according to comments here, so it shouldn't be used to accomplish the goalHow:
New approach follows the latest official
vitestdocumentation. There was also docs fix that I proposed and got approved recently, so thevitestdocs website itself isn't reflecting the latest state. To verify that new approach is aligned with docs, you can check this PRAlong the way I removed
export {}statement since it isn't needed when there areimportstatements are present in the same fileChecklist: