Skip to content

feat(no-node-access): enable in DOM config#661

Merged
Belco90 merged 1 commit intotesting-library:alphafrom
skovy:pr/enable-no-await-sync-events
Oct 2, 2022
Merged

feat(no-node-access): enable in DOM config#661
Belco90 merged 1 commit intotesting-library:alphafrom
skovy:pr/enable-no-await-sync-events

Conversation

@skovy
Copy link
Copy Markdown
Collaborator

@skovy skovy commented Oct 2, 2022 •
edited
Loading

BREAKING CHANGE: enable no-node-access by default in dom shared config

Checks

  • I have read the contributing guidelines.
  • If some rule is added/updated/removed, I've regenerated the rules list (npm run generate:rules-list)
  • If some rule meta info is changed, I've regenerated the plugin shared configs (npm run generate:configs)

Changes

  • Enable the no-node-access rule by default in the DOM shared configuration

Context

Resolves #620

@skovy
feat: enable no-node-access in dom
2460bec 
BREAKING CHANGE: enable no-node-access by default in dom config
@Belco90 Belco90 merged commit b9a3198 into testing-library:alpha Oct 2, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 2, 2022

🎉 This PR is included in version 6.0.0-alpha.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Belco90
Copy link
Copy Markdown
Member

Belco90 commented Oct 2, 2022

@all-contributors please add @skovy for code, test, and docs

@allcontributors
Copy link
Copy Markdown
Contributor

allcontributors bot commented Oct 2, 2022

@Belco90

@skovy already contributed before to code, test, doc

@Belco90
Copy link
Copy Markdown
Member

Belco90 commented Oct 2, 2022

@Belco90

@skovy already contributed before to code, test, doc

Oops, I didn't realized about that! Thanks for your amazing work on v6 @skovy.

@MichaelDeBoey MichaelDeBoey added the v6 Next major v6 label Oct 2, 2022
@skovy skovy deleted the pr/enable-no-await-sync-events branch October 2, 2022 22:31
@MichaelDeBoey MichaelDeBoey added the BREAKING CHANGE This change will require a major version bump label Oct 4, 2022
@MichaelDeBoey MichaelDeBoey changed the title feat: enable no-node-access in dom shared config feat(no-node-access): enable in DOM config Oct 4, 2022
@MichaelDeBoey MichaelDeBoey linked an issue Oct 4, 2022 that may be closed by this pull request
Enable no-node-access in corresponding shareable config #620
Closed
MichaelDeBoey pushed a commit that referenced this pull request Oct 4, 2022
@skovy @MichaelDeBoey
feat(no-node-access): add to DOM config by default (#661)
8dfe155 
BREAKING CHANGE: `no-node-access` is now enabled by default in the DOM config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Belco90 Belco90 Belco90 approved these changes

Assignees

No one assigned

Labels

BREAKING CHANGE This change will require a major version bump hacktoberfest-accepted released on @alpha v6 Next major v6

Projects

No open projects
eslint-plugin-testing-library v6
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable no-node-access in corresponding shareable config

3 participants

@skovy @Belco90 @MichaelDeBoey