smlbench single container (for comparison)#73
Merged
daviddias merged 4 commits intoplan-smlbenchfrom Oct 20, 2019
Merged
Conversation
added 3 commits
October 16, 2019 20:07
If not defined, Docker build still works.
Changed Docker base image to Debian because busybox or alpine don't work with our precompiled ipfs binaries. Also added a small delay when destroying the ensemble to avoid a race.
Merged
Contributor
|
@jimpick mind resolving the merge conflicts for a clean merge/comparison? Thank you so much for pushing for this :) |
daviddias
approved these changes
Oct 20, 2019
Contributor
daviddias
left a comment
There was a problem hiding this comment.
Thank you for getting the last mile of this one to work :)
daviddias
pushed a commit
that referenced
this pull request
Oct 20, 2019
* Get smlbench to compile (no tests) * Include go-ipfs in Docker image when go_ipfs_version is defined If not defined, Docker build still works. * Get smlbench working again Changed Docker base image to Debian because busybox or alpine don't work with our precompiled ipfs binaries. Also added a small delay when destroying the ensemble to avoid a race.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For ease of comparison against PR #60 - not intended to be merged as is
This particular branch gets the smlbench test case working again ... however, it's only executing the old IPTB based test inside a single Docker instance, which is probably not what we ultimately want.
Run it with a single container, eg:
or
I modified the Dockerfile.template to call
install-ipfs.shif go_ipfs_version is set in the manifest. I also had to change the base image to debian from busybox in order to be compatible with the prebuilt IPFS binaries distributed from dist.ipfs.io. If I was to do it again, I think I'd prefer a mechanism where I could have a different Dockerfile for some test cases instead of sharing it between all test cases.