Skip to content

adding StateCanceled for task ; adding kill cmd ; refactor Task ; extract timeouts#1156

Merged
nonsense merged 26 commits intotasks-statusfrom
tasks-status-next
Oct 6, 2020
Merged

adding StateCanceled for task ; adding kill cmd ; refactor Task ; extract timeouts#1156
nonsense merged 26 commits intotasks-statusfrom
tasks-status-next

Conversation

@nonsense
Copy link
Copy Markdown
Member

@nonsense nonsense commented Oct 2, 2020

Relies on:

We should either first merge these PRs, or merge this into tasks-status and do an overall review.


This PR is:

  1. Adding a kill command, so that we can cancel tasks that are currently processing or scheduled.
  2. Refactoring Task package - making impl. details private (such as prefixes for the LevelDB schema) and unifying the names between the in-memory Queue and the Task.
  3. Explicitly adding a StateCanceled for tasks.
  4. Extracting task timeout as a config. We now have two timeouts:
    a) task includes both the build and run duration of a task. Consider it as a global timeout.
    b) run is the timeout of the run part of a test plan. It should be less that task timeout.
  5. Adding user field to the [client] testground config. This field is attached to tasks so that we identify who triggered a task.

@nonsense nonsense force-pushed the tasks-status-next branch 3 times, most recently from 92df386 to a7eed02 Compare October 5, 2020 18:25
@nonsense nonsense force-pushed the tasks-status-next branch 4 times, most recently from 6031a1c to b72e1fe Compare October 5, 2020 21:10
@nonsense nonsense marked this pull request as ready for review October 6, 2020 12:52
@nonsense
Copy link
Copy Markdown
Member Author

nonsense commented Oct 6, 2020

@raulk actually I am merging this, because it is getting difficult to maintain a working build between various branches on:
go-sdk
testground
lotus
lotus-soup test plan

I am reducing a bit complexity here, and will address comments directly on #1154 after we make review and merge go-sdk.

@nonsense nonsense merged commit 211b576 into tasks-status Oct 6, 2020
@nonsense nonsense deleted the tasks-status-next branch October 6, 2020 13:00
nonsense added a commit that referenced this pull request Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant