adding StateCanceled for task ; adding kill cmd ; refactor Task ; extract timeouts#1156
Merged
nonsense merged 26 commits intotasks-statusfrom Oct 6, 2020
Merged
adding StateCanceled for task ; adding kill cmd ; refactor Task ; extract timeouts#1156nonsense merged 26 commits intotasks-statusfrom
nonsense merged 26 commits intotasks-statusfrom
Conversation
f1ff20a to
572bb62
Compare
92df386 to
a7eed02
Compare
a7eed02 to
9c068a7
Compare
6031a1c to
b72e1fe
Compare
b72e1fe to
1b8a90f
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relies on:
We should either first merge these PRs, or merge this into
tasks-statusand do an overall review.This PR is:
killcommand, so that we can cancel tasks that are currently processing or scheduled.Taskpackage - making impl. details private (such asprefixesfor the LevelDB schema) and unifying the names between the in-memory Queue and the Task.StateCanceledfor tasks.tasktimeout as a config. We now have two timeouts:a)
taskincludes both thebuildandrunduration of a task. Consider it as a global timeout.b)
runis the timeout of the run part of a test plan. It should be less thattasktimeout.userfield to the[client]testground config. This field is attached to tasks so that we identify who triggered a task.