eks: Implement deploy script and guide for EKS#78
Conversation
|
Looks like my tasks from http://a496563c54d424aee8c6ab8e02ce2b6c-869758685.eu-west-3.elb.amazonaws.com/tasks are gone. There might be some storage misconfiguration. |
|
As for IPv6, let's not include it in this PR. |
|
@laurentsenta is going to go through all the open comments and he's going to gather the ones that have to be handled as part of this PR and discard the rest. He's going to post a summary as a comment. |
|
@dektech @brdji thanks for the work on these PRs. Tracking all these discussions in each PRs is getting tricky, here is the summary as a list of tasks: testground/testground#1499 |
Here's a quick recap of what's happening:
Should this error occur too frequently, I would suggest opening up an investigation, and adding a custom cleanup step to the watch func. Something like: |
I don't quite get this explanation. I understand why we can't schedule new things when all of the above happens but why doesn't our cleanup work? Specifically this: Are we doing that in the wrong context? Is it too late? Can we do something about it? I'd say that when you stop a plan, the expectation is for all the pods to be removed immediately. |
The problem seems be caused by the pod scheduling request sent to kubernetes:
The error To summarize: while I believe we can do something about it (ie. once the error occurs, cancel the scheduling request, etc.), I don't think it is easy to get to the bottom of this issue, and it would require opening a more in-depth investigation, one that is out of scope of this task. |
|
Thanks for the updates, feels much better now :) Here's my feedback from the most recent testing session: testground/testground#1518 |
laurentsenta
left a comment
There was a problem hiding this comment.
Thanks for sharing and updating the PR,
We can merge as is and close testground/testground#1499, congrats @dektech and team !
The Follow-up task list is in testground/testground#1500.
This review contains all the required changes for the new EKS cluster. Most of the changes relate to network annotations, IP ranges, configuration options, etc. Closes #1499 A related change in the infra: testground/infra#78 Co-authored-by: AbominableSnowman730 <abominablesnowman730@gmail.com> Co-authored-by: LudiSistemas <portalscg@gmail.com> Co-authored-by: Laurent Senta <laurent@singulargarden.com>
Following the discussion on #1389, opening a PR for better visibility and easier commenting/suggestions.
This branch contains a script that will create an EKS cluster with all necessary additions, including 2 nodegroups - infra and plan.
It also includes a detailed, step by step guide.
Please feel free to go through the materials and test the script, and let us know if anything needs to be added or amended.
Review
This feature will take some time to review and test, this is our current status:
@galargh
@laurentsenta