Merged
Conversation
Contributor
Author
|
Hi @eddumelendez! Just hoping I can get this new module on your radar for review.🤞 |
eddumelendez
requested changes
Feb 21, 2024
Member
eddumelendez
left a comment
There was a problem hiding this comment.
Hi, thanks for your contribution. I've left some comments. Also, I think the module should be Grafana instead, later we can add more implementations for other Grafana products.
modules/k6/src/main/java/org/testcontainers/k6/K6Container.java
Outdated
Show resolved
Hide resolved
modules/k6/src/main/java/org/testcontainers/k6/K6Container.java
Outdated
Show resolved
Hide resolved
modules/k6/src/main/java/org/testcontainers/k6/K6Container.java
Outdated
Show resolved
Hide resolved
modules/k6/src/main/java/org/testcontainers/k6/K6Container.java
Outdated
Show resolved
Hide resolved
7649f91 to
cdc6505
Compare
Contributor
Author
|
@eddumelendez thank you for the thorough review! 🙇 I've applied your requested changes except for changing the module name as noted in the unresolved comment. Please let me know what you think. |
modules/k6/src/test/java/org/testcontainers/k6/K6ContainerTests.java
Outdated
Show resolved
Hide resolved
eddumelendez
previously approved these changes
Feb 27, 2024
Member
|
Thanks for your contribution, @javaducky ! |
fokion
pushed a commit
to fokion/testcontainers-java
that referenced
this pull request
Jan 18, 2025
Co-authored-by: Eddú Meléndez <eddu.melendez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the execution of k6 test scripts as a Testcontainer.
This brings feature parity for k6 to the Java implementation from the Go implementation.