fixes bug where extra connection params were only passed to the first connection in a pool #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nections in a pool
Member
|
Note to self: check whether #594 resolves this or whether we need to integrate this PR into it. |
Member
|
Sorry for the delay in looking at this properly. Do you happen to have a test case for this? It'd be good to guard against regression. |
Author
|
this is redundant now, has been resolved in a different way here #604 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes bug where extra connection params weren't passed to all the connections in a pool.
I couldn't figure out how to get access to the connection properties via jdbc, so there's no test here.