Do not add /dummy bind to Ryuk if checks are disabled #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 12, 2018
kiview
approved these changes
Mar 12, 2018
| } | ||
|
|
||
| @SneakyThrows(InterruptedException.class) | ||
| public static String start(String hostIpAddress, DockerClient client, boolean withDummyMount) { |
Member
There was a problem hiding this comment.
Maybe a small Javadoc at this method would help future generations to understand that the withDummyMount variable is used for performing the pre-flight checks (there is the implementation comment a couple of times further of course).
Member
Author
There was a problem hiding this comment.
TBH I consider this method as an internal API (just in Java we cannot do "internal" scope in different packages.... yet :) ) and added an overload just in case :)
rnorth
approved these changes
Mar 13, 2018
Member
|
Looks fine to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.