Skip to content

Return default for empty environment variable#5983

Merged
eddumelendez merged 1 commit into
testcontainers:mainfrom
roulpriya:issue-5026
Oct 10, 2022
Merged

Return default for empty environment variable#5983
eddumelendez merged 1 commit into
testcontainers:mainfrom
roulpriya:issue-5026

Conversation

@roulpriya

Copy link
Copy Markdown
Contributor

Check environment variables and return default if it is empty

Fixes #5026

@roulpriya roulpriya requested a review from a team October 10, 2022 14:40
Signed-off-by: Priyambada Roul <roulpriyambada@gmail.com>
@eddumelendez

Copy link
Copy Markdown
Member

thanks for your contribution @roulpriya ! Can you run ./gradlew :testcontainers:spotlessApply, please? that would fix the build

@eddumelendez eddumelendez added this to the next milestone Oct 10, 2022
@roulpriya

Copy link
Copy Markdown
Contributor Author

@eddumelendez Yes, I've done.

@eddumelendez eddumelendez merged commit 914769f into testcontainers:main Oct 10, 2022
@eddumelendez

eddumelendez commented Oct 10, 2022

Copy link
Copy Markdown
Member

thank you so much @roulpriya ! this is now merged in main branch.

@roulpriya

Copy link
Copy Markdown
Contributor Author

Thankyou @eddumelendez
Looking forward to contributing more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'EnvironmentAndSystemPropertyClientProviderStrategy' should handle empty DOCKER_HOST

2 participants