docs(redpanda): update sasl authentication option to use scram sha 256#3126
Merged
mdelapenya merged 4 commits intotestcontainers:mainfrom May 7, 2025
Merged
docs(redpanda): update sasl authentication option to use scram sha 256#3126mdelapenya merged 4 commits intotestcontainers:mainfrom
mdelapenya merged 4 commits intotestcontainers:mainfrom
Conversation
Highlight that the sasl authentication uses scram sha 256 (I spent some time trying to connect with 512 until I realize my mistake)
❌ Deploy Preview for testcontainers-go failed.
|
mdelapenya
previously approved these changes
Apr 26, 2025
Member
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM thanks!
Could you also update the docs at ./docs/modules/redpanda.md? 🙏
Member
|
@peczenyj could you update the |
Contributor
Author
|
Done |
mdelapenya
approved these changes
May 7, 2025
Member
mdelapenya
left a comment
There was a problem hiding this comment.
I kicked off the CI, once passed (it will 😄 ) we are good to merge, thanks for your work here with the documentation, they are pretty important to us!
LGTM!
mdelapenya
added a commit
to waroir20/testcontainers-go
that referenced
this pull request
May 15, 2025
* main: feat: support adding wait strategies as functional option (testcontainers#3161) fix(etcd): expose ports for the etcd nodes (testcontainers#3162) fix(wait): no port to wait for (testcontainers#3158) feat: add more functional options for customising containers (testcontainers#3156) docs(redpanda): update sasl authentication option to use scram sha 256 (testcontainers#3126)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Jun 3, 2025
* main: (236 commits) feat(kafka,redpanda): support for waiting for mapped ports without external checks (testcontainers#3165) chore: bump ryuk to 0.12.0 (testcontainers#3195) feat!: add options when creating RawCommand (testcontainers#3168) chore(deps)!: bump github.com/docker/docker from 28.1.1+incompatible to 28.2.2+incompatible (testcontainers#3194) feat(couchbase): adding auth to couchbase initCluster functions to support container reuse (testcontainers#3048) chore(deps): bump github.com/containerd/containerd/v2 (testcontainers#3167) docs(options): refactor options layout in modules (testcontainers#3163) fix(ci): do not run sonar for Testcontainers Cloud (testcontainers#3166) chore(ci): do not fail fast in the Testcontainers Cloud run (testcontainers#3164) feat: support adding wait strategies as functional option (testcontainers#3161) fix(etcd): expose ports for the etcd nodes (testcontainers#3162) fix(wait): no port to wait for (testcontainers#3158) feat: add more functional options for customising containers (testcontainers#3156) docs(redpanda): update sasl authentication option to use scram sha 256 (testcontainers#3126) chore(deps): bump mkdocs-include-markdown-plugin from 6.2.2 to 7.1.5 (testcontainers#3137) chore(deps): bump github.com/shirou/gopsutil/v4 from 4.25.1 to 4.25.4 (testcontainers#3133) chore(deps): bump github.com/docker/docker from 28.0.1+incompatible to 28.1.1+incompatible (testcontainers#3152) feat(memcached): add memcached module (testcontainers#3132) fix(etcd): single node etcd cluster access (testcontainers#3149) feat(valkey): add TLS support for Valkey (testcontainers#3131) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlight that the sasl authentication uses scram sha 256 (I spent some time trying to connect with 512 until I realize my mistake)
What does this PR do?
Update go doc expanding some existing information
Why is it important?
I think we should be explicit about sasl uses scram sha 256
Related issues
N/A