Skip to content

fix: use empty dir for the core#3035

Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom
mdelapenya:fix-sonar-paths
Mar 14, 2025
Merged

fix: use empty dir for the core#3035
mdelapenya merged 1 commit intotestcontainers:mainfrom
mdelapenya:fix-sonar-paths

Conversation

@mdelapenya
Copy link
Member

@mdelapenya mdelapenya commented Mar 14, 2025

Use the empty path for the core library

@mdelapenya mdelapenya requested a review from a team as a code owner March 14, 2025 17:40
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Mar 14, 2025
@netlify
Copy link

netlify bot commented Mar 14, 2025

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 9e1973d
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/67d46a168badba00085b0eff
😎 Deploy Preview https://deploy-preview-3035--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member Author

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created the project using the REST APIs: https://community.sonarsource.com/t/monorepo-how-to-add-subprojects-automatically-to-the-parent-project-when-a-build-is-triggered/136819/3

We must create the new project on Sonarcloud when a new project is created.

@mdelapenya mdelapenya merged commit b50cd36 into testcontainers:main Mar 14, 2025
185 checks passed
@mdelapenya mdelapenya deleted the fix-sonar-paths branch March 14, 2025 18:12
mdelapenya added a commit that referenced this pull request Mar 17, 2025
…er-28.0.1incompatible

* main:
  chore!: export DockerCompose type in compose package (#2953)
  chore(deps): bump golang.org/x/net from 0.33.0 to 0.36.0 in /modules (#3033)
  chore(sonar): set main as default branch (#3038)
  fix(sonar): run on ubuntu and the lowest Go version (#3037)
  fix(ci): update core path in sonar build (#3036)
  fix: use empty dir for the core (#3035)
  fix: pass secret to the reusable workflow (#3034)
  chore(ci): use new GH action for SonarQube (#3007)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Mar 17, 2025
* main:
  chore(deps)!: bump github.com/docker/docker from 27.1.1+incompatible to 28.0.1+incompatible (testcontainers#3017)
  chore!: export DockerCompose type in compose package (testcontainers#2953)
  chore(deps): bump golang.org/x/net from 0.33.0 to 0.36.0 in /modules (testcontainers#3033)
  chore(sonar): set main as default branch (testcontainers#3038)
  fix(sonar): run on ubuntu and the lowest Go version (testcontainers#3037)
  fix(ci): update core path in sonar build (testcontainers#3036)
  fix: use empty dir for the core (testcontainers#3035)
  fix: pass secret to the reusable workflow (testcontainers#3034)
  chore(ci): use new GH action for SonarQube (testcontainers#3007)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Changes that do not impact the existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant