Skip to content

docs: correct container variable#3010

Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom
tacerus:container-doc
Mar 8, 2025
Merged

docs: correct container variable#3010
mdelapenya merged 1 commit intotestcontainers:mainfrom
tacerus:container-doc

Conversation

@tacerus
Copy link
Contributor

@tacerus tacerus commented Mar 8, 2025

What does this PR do?

Repair a code example.

Why is it important?

Because working examples make people happy.

Related issues

n/a

n/a

n/a

Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
@tacerus tacerus requested a review from a team as a code owner March 8, 2025 14:28
@netlify
Copy link

netlify bot commented Mar 8, 2025

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 1906451
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/67cc53f252ee550008c354db
😎 Deploy Preview https://deploy-preview-3010--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, we usually try to embed code snippets directly from the source code, to about what you wisely points out, and this one seems it's not using this approach, so thank you very much for fixing the docs.

LGTM

@mdelapenya mdelapenya added the documentation Docs, docs, docs. label Mar 8, 2025
@mdelapenya mdelapenya self-assigned this Mar 8, 2025
@mdelapenya mdelapenya merged commit 47c5c77 into testcontainers:main Mar 8, 2025
16 checks passed
@tacerus tacerus deleted the container-doc branch March 8, 2025 19:24
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Mar 11, 2025
* main:
  docs: refine texts on how to set the module image (testcontainers#3012)
  feat(modules): add dind module (testcontainers#3004)
  docs: correct container variable (testcontainers#3010)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Mar 11, 2025
* main:
  docs: refine texts on how to set the module image (testcontainers#3012)
  feat(modules): add dind module (testcontainers#3004)
  docs: correct container variable (testcontainers#3010)
  chore: update Weaviate version to v1.29.0 and Weaviate Go client to v5.0.2 (testcontainers#3006)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Mar 13, 2025
* main:
  chore(deps): bump github.com/opencontainers/image-spec from 1.1.0 to 1.1.1, dario.cat/mergo from 1.0.0 to 1.0.1 (testcontainers#3030)
  chore(deps): bump github/codeql-action from 3.28.0 to 3.28.11 (testcontainers#3014)
  chore(deps): bump ossf/scorecard-action from 2.4.0 to 2.4.1 (testcontainers#3013)
  chore: readd dependabot, including a way to refresh the project files for all the modules (testcontainers#2997)
  docs: refine texts on how to set the module image (testcontainers#3012)
  feat(modules): add dind module (testcontainers#3004)
  docs: correct container variable (testcontainers#3010)
  chore: update Weaviate version to v1.29.0 and Weaviate Go client to v5.0.2 (testcontainers#3006)
  chore(deps): bump docker/setup-docker-action from 4.1.0 to 4.2.0 (testcontainers#3002)
  docs: fix typo in Grafana lgtm module (testcontainers#2999)
  feat: add ScyllaDB module (testcontainers#2992)
  feat(mssql): add WithInitSQL function (testcontainers#2988)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Mar 13, 2025
* main:
  chore(deps): bump github.com/opencontainers/image-spec from 1.1.0 to 1.1.1, dario.cat/mergo from 1.0.0 to 1.0.1 (testcontainers#3030)
  chore(deps): bump github/codeql-action from 3.28.0 to 3.28.11 (testcontainers#3014)
  chore(deps): bump ossf/scorecard-action from 2.4.0 to 2.4.1 (testcontainers#3013)
  chore: readd dependabot, including a way to refresh the project files for all the modules (testcontainers#2997)
  docs: refine texts on how to set the module image (testcontainers#3012)
  feat(modules): add dind module (testcontainers#3004)
  docs: correct container variable (testcontainers#3010)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Docs, docs, docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants