Move the file and mounts tests into a test package#2270
Merged
mdelapenya merged 2 commits intotestcontainers:mainfrom Mar 1, 2024
Merged
Conversation
This work has been extracted from testcontainers#2202 and is related to testcontainers#2180. See the original PR for the full context and reasoning. This will help with the documentation, since all examples will now have the module prefixes.
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
reviewed
Feb 29, 2024
Member
mdelapenya
left a comment
There was a problem hiding this comment.
This initially LGTM, just a comment regarding a file name, not a blocker
mdelapenya
added a commit
to jespino/testcontainers-go
that referenced
this pull request
Mar 1, 2024
* main: chore: bump Go version to 1.21 (testcontainers#2292) chore(deps): bump github.com/ClickHouse/clickhouse-go/v2 (testcontainers#2226) feat: WithLogger ContainerCustomizer support (testcontainers#2259) chore(deps): bump github.com/jackc/pgx/v5 in /modules/cockroachdb (testcontainers#2217) Move the file and mounts tests into a test package (testcontainers#2270) Fix Dockerfile not located when added to dockerignore (testcontainers#2272)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This work has been extracted from #2202 and is related to #2180. See the original PR for the full context and reasoning.
Why is it important?
This will help with the documentation, since all examples will now have the module prefixes.
Related issues