feat: Add Minio module#2132
Merged
mdelapenya merged 19 commits intotestcontainers:mainfrom Jan 25, 2024
adoublef:feat/minio
Merged
feat: Add Minio module#2132mdelapenya merged 19 commits intotestcontainers:mainfrom adoublef:feat/minio
mdelapenya merged 19 commits intotestcontainers:mainfrom
adoublef:feat/minio
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
48 tasks
Contributor
Author
|
Looks like the test is failing for me not generating an examples/minio. Is this required giving the module generated also included an test example |
mdelapenya
reviewed
Jan 22, 2024
mdelapenya
requested changes
Jan 24, 2024
Member
mdelapenya
left a comment
There was a problem hiding this comment.
Added a few comments, PTAL before merging.
Thanks!
Minio is already included in modules group Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>
mdelapenya
reviewed
Jan 24, 2024
mdelapenya
reviewed
Jan 24, 2024
Member
mdelapenya
left a comment
There was a problem hiding this comment.
@adoublef I think this module is ready to be merged, only pending the docs for the functional options.
Once there, I'll merge it, thanks!
mdelapenya
reviewed
Jan 24, 2024
Member
|
@adoublef I went ahead and pushed the changes on top of yours. Once the CI passes, I think we are good to go, thanks! |
mdelapenya
previously approved these changes
Jan 24, 2024
Member
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding a new module!
Contributor
Author
Thank you. Also it looks like golangci is failing the test for minio and cockroachdb. is this something I should be concerned about? |
Member
At the moment there are changes in the core project's dependencies, they must be propagated to all the modules, so running Thanks! |
mdelapenya
added a commit
to rcrowe/testcontainers-go
that referenced
this pull request
Jan 25, 2024
* main: Bump containerd version to v1.7.12 (testcontainers#2137) feat: Add Minio module (testcontainers#2132) Adding LogConsumers start as part of the ContainerRequest (testcontainers#2073) chore: bring back assertion for network aliases for bridge in rootless mode (testcontainers#2141) chore(deps): bump github.com/docker/compose/v2 from 2.23.3 to 2.24.0 in /modules/compose (testcontainers#2096)
mdelapenya
added a commit
to laskoviymishka/testcontainers-go
that referenced
this pull request
Jan 26, 2024
* main: Adding inbucket module (testcontainers#2142) testifylint: enable compares rule (testcontainers#2143) Bump containerd version to v1.7.12 (testcontainers#2137) feat: Add Minio module (testcontainers#2132) Adding LogConsumers start as part of the ContainerRequest (testcontainers#2073) chore: bring back assertion for network aliases for bridge in rootless mode (testcontainers#2141) chore(deps): bump github.com/docker/compose/v2 from 2.23.3 to 2.24.0 in /modules/compose (testcontainers#2096)
mdelapenya
added a commit
to tateexon/testcontainers-go
that referenced
this pull request
Jan 29, 2024
* main: (74 commits) chore(deps): bump github.com/docker/compose/v2 in /modules/compose (testcontainers#2162) feat(modules.cockroachdb) Adds cockroachdb module (testcontainers#2131) chore(deps): bump golang.org/x/crypto in /modules/minio (testcontainers#2161) chore(deps): bump golang.org/x/crypto in /modules/openldap (testcontainers#2165) chore(deps): bump github.com/google/uuid from 1.5.0 to 1.6.0 (testcontainers#2169) chore(deps): bump google.golang.org/api from 0.156.0 to 0.159.0, google.golang.org/grpc from 1.60.1 to 1.61.0, cloud.google.com/go/pubsub from 1.33.0 to 1.35.0 in /modules/gcloud (testcontainers#2168) chore(deps): bump github.com/hashicorp/consul/api in /examples/consul (testcontainers#2152) chore(deps): bump github.com/couchbase/gocb/v2 in /modules/couchbase (testcontainers#2145) chore(deps): bump k8s.io/api, k8s.io/apimachinery and k8s.io/client-go from 0.29.0 to 0.29.1 in /modules/k3s (testcontainers#2167) chore: do not compile modules on macos workers on GH (testcontainers#2164) Openldap module support (testcontainers#2117) Adding inbucket module (testcontainers#2142) testifylint: enable compares rule (testcontainers#2143) Bump containerd version to v1.7.12 (testcontainers#2137) feat: Add Minio module (testcontainers#2132) Adding LogConsumers start as part of the ContainerRequest (testcontainers#2073) chore: bring back assertion for network aliases for bridge in rootless mode (testcontainers#2141) chore(deps): bump github.com/docker/compose/v2 from 2.23.3 to 2.24.0 in /modules/compose (testcontainers#2096) chore(deps): bump github.com/dvsekhvalnov/jose2go in /modules/pulsar (testcontainers#2136) fix: skip-host-cache option removed in latest MySQL 8.3.0 version (testcontainers#2130) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a Go module for Minio including the following features:
Why is it important?
Adding modules is always great, minio is a widely used s3-compatible object store.
Related issues