make ryuk timeouts configurable via properties file#1668
Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom Sep 22, 2023
Merged
make ryuk timeouts configurable via properties file#1668mdelapenya merged 1 commit intotestcontainers:mainfrom
mdelapenya merged 1 commit intotestcontainers:mainfrom
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This adds two new properties, like
ryuk.connection.timeout=2m
ryuk.reconnection.timeout=3m
to control the timeouts used with the reaper container.
Their defaults are 1 minute (connection) and 10 seconds (reconnection),
matching the defaults of the ryuk container's env vars.
Signed-off-by: Stephan Renatus <stephan@styra.com>
49607c0 to
1f5d34e
Compare
mdelapenya
approved these changes
Sep 22, 2023
Member
mdelapenya
left a comment
There was a problem hiding this comment.
This looks great! Thanks for being so quick with the implementation.
LGTM
Member
Could you elaborate a bit more, maybe in a different issue? 🙏 |
Contributor
Author
Sure! I'll try to isolate the issue and share the test file -- in another issue -- early next week 🤞 |
Contributor
Author
|
✔️ #1671 |
mdelapenya
added a commit
that referenced
this pull request
Sep 25, 2023
…util/v3-3.23.8 * main: chore(deps): bump github.com/IBM/sarama in /modules/kafka (#1637) chore(deps): bump github.com/ClickHouse/clickhouse-go/v2 (#1625) chore(deps): bump github.com/elastic/go-elasticsearch/v8 (#1641) chore(deps): bump github.com/tidwall/gjson from 1.16.0 to 1.17.0 in /modules/couchbase and /modules/vault (#1684) chore(deps): bump mkdocs from 1.5.2 to 1.5.3 (#1662) chore(deps): bump github.com/nats-io/nats.go in /modules/nats (#1657) chore(deps): bump k8s.io/apimachinery from 0.28.1 to 0.28.2 and k8s.io/client-go from 0.28.1 to 0.28.2 in /modules/k3s (#1683) chore(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.18.39 to 1.18.42 and github.com/aws/aws-sdk-go from 1.45.3 to 1.45.15 and github.com/aws/aws-sdk-go-v2/service/s3 from 1.38.5 to 1.39.0 in /modules/localstack (#1680) chore(deps): bump github.com/twmb/franz-go/pkg/kadm from 1.9.0 to 1.9.1 and github.com/twmb/franz-go from 1.14.4 to 1.15.0 in /modules/redpanda (#1682) chore(deps): bump cloud.google.com/go/datastore from 1.13.0 to 1.14.0 and google.golang.org/grpc from 1.58.1 to 1.58.2 and cloud.google.com/go/spanner from 1.47.0 to 1.49.0 in /modules/gcloud (#1681) feat: add GCloud module (#1670) make ryuk timeouts configurable via properties file (#1668) chore(deps): bump mkdocs-material from 8.2.7 to 9.3.2 (#1649) chore(deps): bump google.golang.org/grpc from 1.57.0 to 1.58.1 and google.golang.org/api from 0.138.0 to 0.142.0 in /examples (#1667) feat: support for loading images in the K3s module (#1622)
mdelapenya
added a commit
that referenced
this pull request
Sep 26, 2023
….com/docker/compose/v2-2.22.0 * main: chore(deps): bump golang.org/x/text to v0.15.0 (#1687) chore(deps): bump github.com/shirou/gopsutil/v3 from 3.23.7 to 3.23.8 (#1651) Wait for k3s node to sync (#1685) chore(deps): bump github.com/IBM/sarama in /modules/kafka (#1637) chore(deps): bump github.com/ClickHouse/clickhouse-go/v2 (#1625) chore(deps): bump github.com/elastic/go-elasticsearch/v8 (#1641) chore(deps): bump github.com/tidwall/gjson from 1.16.0 to 1.17.0 in /modules/couchbase and /modules/vault (#1684) chore(deps): bump mkdocs from 1.5.2 to 1.5.3 (#1662) chore(deps): bump github.com/nats-io/nats.go in /modules/nats (#1657) chore(deps): bump k8s.io/apimachinery from 0.28.1 to 0.28.2 and k8s.io/client-go from 0.28.1 to 0.28.2 in /modules/k3s (#1683) chore(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.18.39 to 1.18.42 and github.com/aws/aws-sdk-go from 1.45.3 to 1.45.15 and github.com/aws/aws-sdk-go-v2/service/s3 from 1.38.5 to 1.39.0 in /modules/localstack (#1680) chore(deps): bump github.com/twmb/franz-go/pkg/kadm from 1.9.0 to 1.9.1 and github.com/twmb/franz-go from 1.14.4 to 1.15.0 in /modules/redpanda (#1682) chore(deps): bump cloud.google.com/go/datastore from 1.13.0 to 1.14.0 and google.golang.org/grpc from 1.58.1 to 1.58.2 and cloud.google.com/go/spanner from 1.47.0 to 1.49.0 in /modules/gcloud (#1681) feat: add GCloud module (#1670) make ryuk timeouts configurable via properties file (#1668) chore(deps): bump mkdocs-material from 8.2.7 to 9.3.2 (#1649) chore(deps): bump google.golang.org/grpc from 1.57.0 to 1.58.1 and google.golang.org/api from 0.138.0 to 0.142.0 in /examples (#1667) feat: support for loading images in the K3s module (#1622)
This was referenced Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds two new properties, like
to control the timeouts used with the reaper container.
Their defaults are 1 minute (connection) and 10 seconds (reconnection), matching the defaults of the ryuk container's env vars.
Why is it important?
In an E2E run, TC had problems re-creating the reaper container after it had stopped because the reconnection timeout was exceeded. With this, we can workaround that problem by increasing the timeout.
Related issues
🗨️ Discussed in Slack
How to test this PR
Unit tests have been updated and added.
Follow-ups
ryuk.verbose=true.