Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

✅ Deploy Preview for testcontainers-dotnet ready!

Name	Link
🔨 Latest commit	476780d
🔍 Latest deploy log	https://app.netlify.com/projects/testcontainers-dotnet/deploys/6935949865c08d0008440b4d
😎 Deploy Preview	https://deploy-preview-1584--testcontainers-dotnet.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Again random Elastic test failure. Need to merge #1593 first I think.

Small overview:

Added two new constructors to each module. ctor(string) and ctor(IImage). They both call Init().WithImage() and pass the argument. Changed existing parameterless constructor to explicitly use old image like Init().WithImage(MODULE_DEFAULT_IMAGE). The old parameterless constructor is deprecated.

Added xml docs to point where image tags can be located, usually hub.docker.com.

Added same two new constructors and deprecated old constructor in ContainerBuilder. I changed almost all internal references to one of the new constuctors.

Added Dockerfile to each test project and wrote a new TestSession.GetImageFromDockerfile() helper. I tried to add latest version of every module in this Dockerfile.
Not all modules currently support latest versions of their images, so I had to put non-latest working image tag for some of them.

Wow, this looks great! Thanks for your hard work. The only issue I noticed is with the xUnit.net module. It won't work anymore in the future. We probably need to use reflection here, even though I try to avoid it as much as possible. We need to think about whether there's another way. WDYT?

The only issue I noticed is with the xUnit.net module.

Yes, this is valid problem, I think we need to make a new issue for it, and make a separate PR. We could for example pass a factory or "creator" delegate if reflection is not an option. Or maybe even use InternalsVisibleTo, and make constructor internal instead of public 😄

Unrelated, but looks like Kafka tests also randomly fail. I already had this failure happen twice in this PR (for unrelated changes).

Unrelated, but looks like Kafka tests also randomly fail. I already had this failure happen twice in this PR (for unrelated changes).

The best way is to test flaky modules in GH Codespaces with a script that runs the specific module tests indefinitely. I just took a quick look: the Kafka tests (seems to) finish in about a minute, but the overall test process doesn't exit and gets cancelled after five minutes.

@HofmeisterAn
Does something else need to be done/fixed or we are good to merge this?

My dockerfile parsing code in GetImageFromDockerfile() is very straightforward, so adding comments in first line(s) broke it :) Probably should ignore lines starting with #. I'll fix it.

My dockerfile parsing code in GetImageFromDockerfile() is very straightforward, so adding comments in first line(s) broke it :) Probably should ignore lines starting with #. I'll fix it.

Ah, I just saw your comment, no worries. I've set the images in the Dockerfile to the versions used in the builder classes for now. We should update the images in a follow-up PR (65a2fc0). OK?

My dockerfile parsing code in GetImageFromDockerfile() is very straightforward, so adding comments in first line(s) broke it :) Probably should ignore lines starting with #. I'll fix it.

Ah, I just saw your comment, no worries. I've set the images in the Dockerfile to the versions used in the builder classes for now. We should update the images in a follow-up PR (65a2fc0). OK?

Yes, but maybe let dependabot update them instead? :)

As a sidenote, while I was searching for latest images I encountered some obstacles such as:

• Some non-docker hub registries is a pain to navigate and look up image tags. For example I couldn't figure IBM's icr and how to see available tags of Db2.
• Some image vendors do not push LTS or even v{Major} tags. They may push current build tagged yyyy-mm-dd. Some even only push latest (Microsoft emulators)!
• Even the vendors who push more or less semvered tags do not always list what is currently supported and/or LTS versions are. I need to guess or go to official docs site.
• Some newer images do not work with our tests at all :) Kafka for example.

I've reviewed everything and made a couple of small changes. LMKWYT. If you're okay with them, we can merge the PR.

Yes, but maybe let dependabot update them instead? :)

👍 Ideally, we can use Dependabot (for most of the images) and rely on its auto-update capabilities.

As a sidenote, while I was searching for latest images I encountered some obstacles such as:

Yeah, unfortunately there isn't much we can do here. There just aren't strict guidelines for images.

Some newer images do not work with our tests at all :) Kafka for example.

Yes, that's expected. It's one of the reasons we're doing this.

These are the follow-ups we should add as TODOs to the issue so we don't forget:

• Prepare a draft PR to update the docs.
• Prepare a draft PR to update the Testcontainers module catalog.
• Update the examples after the 4.10.0 release.

Again, thanks for the work 💪!

LMKWYT. If you're okay with them, we can merge the PR.

I think it's ready for merge. 👍