Skip to content

Completes existing branch with new client dependency for test#1582

Closed
diegosasw wants to merge 0 commit intotestcontainers:feature/add-kurrent-dbfrom
diegosasw:feature/add-kurrent-db
Closed

Completes existing branch with new client dependency for test#1582
diegosasw wants to merge 0 commit intotestcontainers:feature/add-kurrent-dbfrom
diegosasw:feature/add-kurrent-db

Conversation

@diegosasw
Copy link
Contributor

@diegosasw diegosasw commented Nov 17, 2025

What does this PR do?

Completes already started work to support KurrentDB TestContainer. Fixed conflicts, using latest kurrentplatform/kurrentdb:25.1 and replaced EventStore.Client.Grpc.Streams with new KurrentDB.Client in test project

Why is it important?

The branch was incomplete.

Related issues

How to test this PR

Run automated test that writes and reads from KurrentDB test container

@coderabbitai
Copy link

coderabbitai bot commented Nov 17, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example:

"Create a concise high-level summary as a bullet-point list. Then include a Markdown table showing lines added and removed by each contributing author."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@diegosasw
Copy link
Contributor Author

diegosasw commented Nov 17, 2025 •
edited
Loading

@HofmeisterAn it's my first PR, hopefully I didn't do anything wrong 😄
I rebased develop into your branch, fixed conflict, added support for .NET10, added src and test projects to solution and replaced old EventStore client library with the newest Kurrent client one that addresses the problem you had encountered.

UPDATE: It seems rebasing and sending a PR into your existing branch added a lot of noise on the PR so maybe you can review #1583 which should be ready to merge.

@diegosasw diegosasw closed this Nov 17, 2025
@diegosasw diegosasw force-pushed the feature/add-kurrent-db branch from 896a9e5 to 063d409 Compare November 17, 2025 17:28
@diegosasw diegosasw mentioned this pull request Nov 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@diegosasw