chore: bump build system versions#45
Conversation
HofmeisterAn
left a comment
There was a problem hiding this comment.
The docker/setup-*@v1 actions are outdated in build-docker-image.yml. docker/setup-buildx-action@v1 shows following warning:
##[warning]The
set-outputcommand is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
##[warning]Thesave-statecommand is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
May not relate to this PR, but should we update them to v2?
Indeed. I'll add them to this PR as a general bump of versions. I can rename the PR |
* main: feat: add golangci-lint (testcontainers#48) chore: add unit tests for Prune function (testcontainers#46) chore(ci): only push Docker image on tags (testcontainers#47) chore: bump build system versions (testcontainers#45) chore: rename branch to main (testcontainers#44)
What does this PR do?
make verifyWhy is it important?
Go 1.17 reached EOL on Aug 2th, 2022 (see https://endoflife.date/go) for that reason we are bumping it to 1.18.
In order to get gamiliar with the codebase, I tried to run the tests, finding issues with outdated dependencies: sys and sirupsen (both indirect). After fixing them, I noticed the GH action was not running the tests, that's why I added a step in the workflow to verify the project.
Follows-up
The existing
make lintis not valid anymore. I'm planning to use golangci-lint as part ofpre-commit