fix(gh-actions): depend on the right workflow#138
Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom Jul 15, 2024
Merged
fix(gh-actions): depend on the right workflow#138mdelapenya merged 1 commit intotestcontainers:mainfrom
mdelapenya merged 1 commit intotestcontainers:mainfrom
Conversation
Member
Author
|
@gesellix I think we screwed it up in #120. Could you take a look 🙏 I'm planning a new release and it failed https://github.com/testcontainers/moby-ryuk/actions/runs/9942721870 Thank you in advance! |
gesellix
approved these changes
Jul 15, 2024
Contributor
gesellix
left a comment
There was a problem hiding this comment.
Yes, I also think that's a leftover/copy&paste-error from the normal build workflow. The fix looks correct to me. 👍
gesellix
added a commit
to gesellix/testcontainers-helloworld
that referenced
this pull request
Jul 15, 2024
gesellix
added a commit
to gesellix/testcontainers-helloworld
that referenced
this pull request
Jul 15, 2024
Contributor
|
@mdelapenya this one is also up-to-date now, including the fixed workflow reference: testcontainers/helloworld#5 |
mdelapenya
pushed a commit
to testcontainers/helloworld
that referenced
this pull request
Aug 7, 2024
* Build multi-arch image including Windows * Sync workflows from testcontainers/moby-ryuk * Fix workflow reference See testcontainers/moby-ryuk#138 * Sync with the workflows from moby-ryuk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is using the right job when releasing the Ryuk project.
It was possibly wrong after #120