Merged
Conversation
mdelapenya
reviewed
May 24, 2024
Member
|
Mmmm failing again: https://github.com/testcontainers/moby-ryuk/actions/runs/9222172622/job/25373416643 @gesellix could you please take a look? |
Contributor
Author
|
Yes, will do! |
Contributor
Author
|
Oops - my bad: I only fixed the publish workflow, but not the build workflow. I'll create another pull request to fix the build workflow, too. Sorry. |
gesellix
added a commit
to gesellix/moby-ryuk
that referenced
this pull request
May 24, 2024
(cherry picked from commit 36c1681)
Contributor
Author
|
I'll certainly extract a shared action so that the workflows become easier to maintain. This one and #131 are the best examples to have better abstractions and keeping code DRY 😅 |
Member
|
thank you @gesellix! Now the incremental docker images are live https://hub.docker.com/r/testcontainers/ryuk/tags, so we can test them before any release. Thank you for your hard work! |
Contributor
Author
|
That's great! Thanks! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #120