Add support for process based parallel test running on Windows #348
+136
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub: test-unitGH-235, test-unitGH-346 On Windows, file descriptors 3 and above cannot be passed to child processes. So we use `TCPSocket` instead of `IO.pipe`.
Contributor
Author
|
Test results are correct as below. 3.4 on Windows:
475 tests, 1613 assertions, 0 failures, 0 errors, 0 pendings, 6 omissions, 0 notifications
3.4 on Windows + Process:
475 tests, 1613 assertions, 0 failures, 0 errors, 0 pendings, 6 omissions, 0 notificationsBy the way, 3.4 on Windows + Process implementation is slow: 3.4 + Process:
Finished in 1.067083044 seconds.
475 tests, 1625 assertions, 0 failures, 0 errors, 0 pendings, 2 omissions, 0 notifications
3.4 on Windows + Process:
Finished in 6.236543 seconds.
475 tests, 1613 assertions, 0 failures, 0 errors, 0 pendings, 6 omissions, 0 notifications
3.4 on Windows:
Finished in 1.341669 seconds.
475 tests, 1613 assertions, 0 failures, 0 errors, 0 pendings, 6 omissions, 0 notifications |
kou
reviewed
Dec 16, 2025
Member
|
We can improve performance later. |
Contributor
Author
Thanks for saying that. I think that communication between processes (not start TCP server and accept client) may be slow. |
kou
reviewed
Dec 16, 2025
Because this always yields. Co-authored-by: Sutou Kouhei <kou@clear-code.com>
tikkss
added a commit
to tikkss/test-unit
that referenced
this pull request
Jan 8, 2026
GitHub: follow up test-unitGH-348 This patch changes from sequential `spawn` and `accept` to batch them. Because waiting for each worker process to start one by one was slow.
kou
added a commit
that referenced
this pull request
Jan 9, 2026
GitHub: follow up GH-348 This patch changes from sequential `spawn` and `accept` to batch them. Because waiting for each worker process to start one by one was slow. --------- Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub: GH-235, GH-346
On Windows, file descriptors 3 and above cannot be passed to child processes. So we use
TCPSocketinstead ofIO.pipe.