After pkg update, it will check whether the package can be upgraded. So change pkg update&&pkg upgrade to pkg update.

After pkg update, it will check whether the package can be upgraded. So change pkg update&&pkg upgrade to pkg update.

Done!

Oh wait, i'm gonna fix this unbound variable error, it should successfully build now

The icon you are adding on the left will break when text wrap engages when terminal width is less than characters per line.

And $TERMUX_VERSION will expand during build time, not on target device.

Also the motd file should just be text and normally not contain escape sequences since loading terminal may not support them, so it may break for some users. Probably not advisable to add this by default. Other members can give their opinion.

https://unix.stackexchange.com/questions/276185/how-do-i-create-a-dark-blue-text-on-a-bright-white-background-in-motd-in-debian

Also the motd file should just be text and normally not contain escape sequences since loading terminal may not support them, so it may break for some users. Probably not advisable to add this by default. Other members can give their opinion.

https://unix.stackexchange.com/questions/276185/how-do-i-create-a-dark-blue-text-on-a-bright-white-background-in-motd-in-debian

Okay, now i've replaced the unicode characters with white colored spaces, and shortened the lines for supporting the default zoom on termux

and replaced $TERMUX_VERSION with $TERMUX_APP__VERSION_NAME

and replaced $TERMUX_VERSION with $TERMUX_APP__VERSION_NAME

login script uses cat $PREFIX/etc/motd to load motd, so no variables are going to expand. The motd is not a script and is just a text/data file.

and replaced $TERMUX_VERSION with $TERMUX_APP__VERSION_NAME

login script uses cat $PREFIX/etc/motd to load motd, so no variables are going to expand. The motd is not a script and is just a text/data file.

termux-packages/packages/termux-tools/login

Line 4 in 82524e0

cat @TERMUX_PREFIX@/etc/motd

So that means, all lines with "echo -e" wouldn't be executed, and colored spaces, bold and underline wouldn't work

So that means, all lines with "echo -e" wouldn't be executed, and colored spaces, bold and underline wouldn't work

There will no echo -e lines in the motd file created because you are just echoing the escape sequences+text into the file as data. They will render as desired. You are supposed to check output files and test changes when sending pull requests.

@TomJo2000 Provided a way to execute environment variables and colors in motd using ESC characters.
I'll reopen the pull request and fix the motd

Change of plans, i'll add a dynamic motd

Thought I'd drop in here for a quick comment.
We're still looking into how to do this in the least disruptive way possible.

The last thing I'd want is to break something with this.

Now it's ready for building

So.. should i replace wiki with IRC?

The community link already has IRC, so should be fine to remove it.

And instead of wiki, use Docs: https://termux.dev/docs. I will add wiki link there for now, wiki site will not be used in future.

The community link already has IRC, so should be fine to remove it.

And instead of wiki, use Docs: https://termux.dev/docs. I will add wiki link there for now, wiki site will not be used in future.

Done

PR's TERMUX_PKG_VERSION Version is already being used by another approved PR now
And i can't change it because GitHub is gonna show conflict errors

Version needs to be bumped, so please set it to 1.21 and force push to the branch

Version needs to be bumped, so please set it to 1.21 and force push to the branch

Okay, but the PR will show some non related commits

Okay, but the PR will show some non related commits

Please rebase and resolve conflicts to get rid of them

Okay, but the PR will show some non related commits

Please rebase and resolve conflicts to get rid of them

They won't disappear, and the commit related to conflict fix won't appear in git rebase, even after git pull

Okay, but the PR will show some non related commits

Please rebase and resolve conflicts to get rid of them

Please help, the PR is broken now
i can't squash the commits or anything