Specify std::abs overloads in elementwise.cc#95959
Closed
DKLoehr wants to merge 1 commit intotensorflow:masterfrom
Closed
Specify std::abs overloads in elementwise.cc#95959DKLoehr wants to merge 1 commit intotensorflow:masterfrom
DKLoehr wants to merge 1 commit intotensorflow:masterfrom
Conversation
mihaimaruseac
approved these changes
Jun 25, 2025
copybara-service bot
pushed a commit
to google-ai-edge/LiteRT
that referenced
this pull request
Jun 25, 2025
Imported from GitHub PR tensorflow/tensorflow#95959 This is required to build with the most recent version of LLVM's libc++, which moved the `abs` function from `stdlib.h` to `math.h` in llvm/llvm-project#139586. Copybara import of the project: -- 2fa2ab36dae8afc9cf838a5ce1726e4ba48afec6 by Devon Loehr <dloehr@google.com>: Include math.h in elementwise.cc Merging this change closes #95959 FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#95959 from DKLoehr:math 2fa2ab36dae8afc9cf838a5ce1726e4ba48afec6 PiperOrigin-RevId: 775719122
copybara-service bot
pushed a commit
to google-ai-edge/LiteRT
that referenced
this pull request
Jun 25, 2025
Imported from GitHub PR tensorflow/tensorflow#95959 This is required to build with the most recent version of LLVM's libc++, which moved the `abs` function from `stdlib.h` to `math.h` in llvm/llvm-project#139586. Copybara import of the project: -- 2fa2ab36dae8afc9cf838a5ce1726e4ba48afec6 by Devon Loehr <dloehr@google.com>: Include math.h in elementwise.cc Merging this change closes #95959 FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#95959 from DKLoehr:math 2fa2ab36dae8afc9cf838a5ce1726e4ba48afec6 PiperOrigin-RevId: 775719122
mihaimaruseac
suggested changes
Jun 25, 2025
Contributor
mihaimaruseac
left a comment
There was a problem hiding this comment.
From internal review: Need to be and std::abs
Author
|
We're already including cmath and using std::abs everywhere, so I'm not actually sure anymore why it's broken in the first place. I'm looking into it. |
Author
|
Alright, I found a better solution (I hope) that should work for both versions. Please take a look. |
Contributor
|
Hi @DKLoehr , Can you please resolve the conflict? Thanks ! |
Author
|
It looks like #95894 already fixed the problem, so this PR is no longer necessary. Thanks for your help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to build with the most recent version of LLVM's libc++, which moved the
absfunction fromstdlib.htomath.hin llvm/llvm-project#139586. This seems to have affected overload resolution, requiring us to explicitly specify which one to use. The static_cast syntax, though ugly, works with both versions.