Skip to content

Update Abseil to fix MSVC compile error#61582

Closed
johnnkp wants to merge 0 commit intotensorflow:masterfrom
johnnkp:master
Closed

Update Abseil to fix MSVC compile error#61582
johnnkp wants to merge 0 commit intotensorflow:masterfrom
johnnkp:master

Conversation

@johnnkp
Copy link
Copy Markdown
Contributor

@johnnkp johnnkp commented Aug 15, 2023

Currently, MSVC address sanitizer may not be enabled during compilation and cause compilation error. This PR updates Abseil to include the fix of #61435.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Aug 15, 2023
@gbaned gbaned requested a review from mihaimaruseac August 16, 2023 03:23
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Aug 16, 2023
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 16, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 16, 2023
This was referenced Aug 16, 2023
Closed
Closed
copybara-service bot pushed a commit to google/tsl that referenced this pull request Aug 16, 2023
@johnnkp @copybara-github
PR #61582: Update Abseil to fix MSVC compile error
6e6a6fe 
Imported from GitHub PR tensorflow/tensorflow#61582

Currently, MSVC address sanitizer may not be enabled during compilation and cause compilation error. This PR updates Abseil to include the fix of tensorflow/tensorflow#61435.
Copybara import of the project:

--
839589037fa6422acfef9e8f2c546fd693ad71e7 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

Update Abseil to the latest LTS

abseil/abseil-cpp@2927340
--
c89a06dbb02e961c7de4e28ab233c9586bd43912 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Use correct checksum
--
bc3b100f90f849df6ef7997eddb72d9ad3e4a6ce by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Remove merged patch

Merging this change closes #61582

FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#61582 from johnnkp:master ca23429a73c4ab5ada3656ac8eb2bd6830d4e20b
PiperOrigin-RevId: 557373616
copybara-service bot pushed a commit to google/tsl that referenced this pull request Aug 17, 2023
@johnnkp @copybara-github
PR #61582: Update Abseil to fix MSVC compile error
a2331d1 
Imported from GitHub PR tensorflow/tensorflow#61582

Currently, MSVC address sanitizer may not be enabled during compilation and cause compilation error. This PR updates Abseil to include the fix of tensorflow/tensorflow#61435.
Copybara import of the project:

--
839589037fa6422acfef9e8f2c546fd693ad71e7 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

Update Abseil to the latest LTS

abseil/abseil-cpp@2927340
--
c89a06dbb02e961c7de4e28ab233c9586bd43912 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Use correct checksum
--
bc3b100f90f849df6ef7997eddb72d9ad3e4a6ce by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Remove merged patch

Merging this change closes #61582

FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#61582 from johnnkp:master ca23429a73c4ab5ada3656ac8eb2bd6830d4e20b
PiperOrigin-RevId: 557373616
copybara-service bot pushed a commit to google/tsl that referenced this pull request Aug 17, 2023
@johnnkp @copybara-github
PR #61582: Update Abseil to fix MSVC compile error
7b2cdd5 
Imported from GitHub PR tensorflow/tensorflow#61582

Currently, MSVC address sanitizer may not be enabled during compilation and cause compilation error. This PR updates Abseil to include the fix of tensorflow/tensorflow#61435.
Copybara import of the project:

--
839589037fa6422acfef9e8f2c546fd693ad71e7 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

Update Abseil to the latest LTS

abseil/abseil-cpp@2927340
--
c89a06dbb02e961c7de4e28ab233c9586bd43912 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Use correct checksum
--
bc3b100f90f849df6ef7997eddb72d9ad3e4a6ce by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Remove merged patch

Merging this change closes #61582

FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#61582 from johnnkp:master ca23429a73c4ab5ada3656ac8eb2bd6830d4e20b
PiperOrigin-RevId: 557373616
@tjni tjni mentioned this pull request Aug 19, 2023
Closed
copybara-service bot pushed a commit to google/tsl that referenced this pull request Aug 23, 2023
@johnnkp @copybara-github
PR #61582: Update Abseil to fix MSVC compile error
9ebaab7 
Imported from GitHub PR tensorflow/tensorflow#61582

Currently, MSVC address sanitizer may not be enabled during compilation and cause compilation error. This PR updates Abseil to include the fix of tensorflow/tensorflow#61435.
Copybara import of the project:

--
839589037fa6422acfef9e8f2c546fd693ad71e7 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

Update Abseil to the latest LTS

abseil/abseil-cpp@2927340
--
c89a06dbb02e961c7de4e28ab233c9586bd43912 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Use correct checksum
--
bc3b100f90f849df6ef7997eddb72d9ad3e4a6ce by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Remove merged patch

Merging this change closes #61582

FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#61582 from johnnkp:master ca23429a73c4ab5ada3656ac8eb2bd6830d4e20b
PiperOrigin-RevId: 557373616
@gbaned gbaned requested a review from mihaimaruseac August 28, 2023 05:32
@google-ml-butler google-ml-butler bot added the kokoro:force-run Tests on submitted change label Aug 28, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 28, 2023
copybara-service bot pushed a commit to google/tsl that referenced this pull request Aug 28, 2023
@johnnkp @copybara-github
PR #61582: Update Abseil to fix MSVC compile error
926521c 
Imported from GitHub PR tensorflow/tensorflow#61582

Currently, MSVC address sanitizer may not be enabled during compilation and cause compilation error. This PR updates Abseil to include the fix of tensorflow/tensorflow#61435.
Copybara import of the project:

--
839589037fa6422acfef9e8f2c546fd693ad71e7 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

Update Abseil to the latest LTS

abseil/abseil-cpp@2927340
--
c89a06dbb02e961c7de4e28ab233c9586bd43912 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Use correct checksum
--
bc3b100f90f849df6ef7997eddb72d9ad3e4a6ce by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Remove merged patch

Merging this change closes #61582

FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#61582 from johnnkp:master ca23429a73c4ab5ada3656ac8eb2bd6830d4e20b
PiperOrigin-RevId: 557373616
copybara-service bot pushed a commit to google/tsl that referenced this pull request Aug 28, 2023
@johnnkp @copybara-github
PR #61582: Update Abseil to fix MSVC compile error
d782d69 
Imported from GitHub PR tensorflow/tensorflow#61582

Currently, MSVC address sanitizer may not be enabled during compilation and cause compilation error. This PR updates Abseil to include the fix of tensorflow/tensorflow#61435.
Copybara import of the project:

--
839589037fa6422acfef9e8f2c546fd693ad71e7 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

Update Abseil to the latest LTS

abseil/abseil-cpp@2927340
--
c89a06dbb02e961c7de4e28ab233c9586bd43912 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Use correct checksum
--
bc3b100f90f849df6ef7997eddb72d9ad3e4a6ce by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Remove merged patch

Merging this change closes #61582

FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#61582 from johnnkp:master ca23429a73c4ab5ada3656ac8eb2bd6830d4e20b
PiperOrigin-RevId: 557373616
copybara-service bot pushed a commit to google/tsl that referenced this pull request Aug 28, 2023
@johnnkp @copybara-github
PR #61582: Update Abseil to fix MSVC compile error
966b5e1 
Imported from GitHub PR tensorflow/tensorflow#61582

Currently, MSVC address sanitizer may not be enabled during compilation and cause compilation error. This PR updates Abseil to include the fix of tensorflow/tensorflow#61435.
Copybara import of the project:

--
839589037fa6422acfef9e8f2c546fd693ad71e7 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

Update Abseil to the latest LTS

abseil/abseil-cpp@2927340
--
c89a06dbb02e961c7de4e28ab233c9586bd43912 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Use correct checksum
--
bc3b100f90f849df6ef7997eddb72d9ad3e4a6ce by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Remove merged patch

Merging this change closes #61582

FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#61582 from johnnkp:master ca23429a73c4ab5ada3656ac8eb2bd6830d4e20b
PiperOrigin-RevId: 557373616
copybara-service bot pushed a commit to openxla/xla that referenced this pull request Aug 28, 2023
@johnnkp @copybara-github
PR #61582: Update Abseil to fix MSVC compile error
bef91bc 
Imported from GitHub PR tensorflow/tensorflow#61582

Currently, MSVC address sanitizer may not be enabled during compilation and cause compilation error. This PR updates Abseil to include the fix of tensorflow/tensorflow#61435.
Copybara import of the project:

--
839589037fa6422acfef9e8f2c546fd693ad71e7 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

Update Abseil to the latest LTS

abseil/abseil-cpp@2927340
--
c89a06dbb02e961c7de4e28ab233c9586bd43912 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Use correct checksum
--
bc3b100f90f849df6ef7997eddb72d9ad3e4a6ce by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Remove merged patch

Merging this change closes #61582

FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#61582 from johnnkp:master ca23429a73c4ab5ada3656ac8eb2bd6830d4e20b
PiperOrigin-RevId: 557373616
@gbaned gbaned requested a review from mihaimaruseac September 1, 2023 05:18
@mihaimaruseac
Copy link
Copy Markdown
Contributor

mihaimaruseac commented Sep 1, 2023

There are no new commits to review. The blocker here is an internal breakage.

@copybara-service copybara-service bot mentioned this pull request Sep 5, 2023
Closed
@copybara-service copybara-service bot mentioned this pull request Sep 5, 2023
Closed
copybara-service bot pushed a commit to google/tsl that referenced this pull request Sep 6, 2023
@johnnkp @copybara-github
PR #61582: Update Abseil to fix MSVC compile error
4780ae1 
Imported from GitHub PR tensorflow/tensorflow#61582

Currently, MSVC address sanitizer may not be enabled during compilation and cause compilation error. This PR updates Abseil to include the fix of tensorflow/tensorflow#61435.
Copybara import of the project:

--
839589037fa6422acfef9e8f2c546fd693ad71e7 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

Update Abseil to the latest LTS

abseil/abseil-cpp@2927340
--
c89a06dbb02e961c7de4e28ab233c9586bd43912 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Use correct checksum
--
bc3b100f90f849df6ef7997eddb72d9ad3e4a6ce by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Remove merged patch

Merging this change closes #61582

FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#61582 from johnnkp:master 77075a15525039de9c034ab1754deae600066adc
PiperOrigin-RevId: 562769011
copybara-service bot pushed a commit to google/tsl that referenced this pull request Sep 8, 2023
@johnnkp @copybara-github
PR #61582: Update Abseil to fix MSVC compile error
c8a93de 
Imported from GitHub PR tensorflow/tensorflow#61582

Currently, MSVC address sanitizer may not be enabled during compilation and cause compilation error. This PR updates Abseil to include the fix of tensorflow/tensorflow#61435.
Copybara import of the project:

--
839589037fa6422acfef9e8f2c546fd693ad71e7 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

Update Abseil to the latest LTS

abseil/abseil-cpp@2927340
--
c89a06dbb02e961c7de4e28ab233c9586bd43912 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Use correct checksum
--
bc3b100f90f849df6ef7997eddb72d9ad3e4a6ce by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Remove merged patch

Merging this change closes #61582

FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#61582 from johnnkp:master 77075a15525039de9c034ab1754deae600066adc
PiperOrigin-RevId: 562769011
copybara-service bot pushed a commit to google/tsl that referenced this pull request Sep 8, 2023
@johnnkp @copybara-github
PR #61582: Update Abseil to fix MSVC compile error
48bc2aa 
Imported from GitHub PR tensorflow/tensorflow#61582

Currently, MSVC address sanitizer may not be enabled during compilation and cause compilation error. This PR updates Abseil to include the fix of tensorflow/tensorflow#61435.
Copybara import of the project:

--
839589037fa6422acfef9e8f2c546fd693ad71e7 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

Update Abseil to the latest LTS

abseil/abseil-cpp@2927340
--
c89a06dbb02e961c7de4e28ab233c9586bd43912 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Use correct checksum
--
bc3b100f90f849df6ef7997eddb72d9ad3e4a6ce by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Remove merged patch

Merging this change closes #61582

FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#61582 from johnnkp:master 77075a15525039de9c034ab1754deae600066adc
PiperOrigin-RevId: 562769011
@d0k
Copy link
Copy Markdown
Member

d0k commented Sep 8, 2023

Can you also update the lts_20230125 symbols in https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/def_file_filter/def_file_filter.py.tpl ? Without that it doesn't link.

copybara-service bot pushed a commit to openxla/xla that referenced this pull request Sep 8, 2023
@johnnkp @copybara-github
PR #61582: Update Abseil to fix MSVC compile error
d965e37 
Imported from GitHub PR tensorflow/tensorflow#61582

Currently, MSVC address sanitizer may not be enabled during compilation and cause compilation error. This PR updates Abseil to include the fix of tensorflow/tensorflow#61435.
Copybara import of the project:

--
839589037fa6422acfef9e8f2c546fd693ad71e7 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

Update Abseil to the latest LTS

abseil/abseil-cpp@2927340
--
c89a06dbb02e961c7de4e28ab233c9586bd43912 by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Use correct checksum
--
bc3b100f90f849df6ef7997eddb72d9ad3e4a6ce by johnnkp <22496821+johnnkp@users.noreply.github.com>:

absl: Remove merged patch

Merging this change closes #61582

FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#61582 from johnnkp:master 77075a15525039de9c034ab1754deae600066adc
PiperOrigin-RevId: 562769011
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Sep 8, 2023
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Sep 9, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 9, 2023
@gbaned gbaned added ready to pull PR ready for merge process kokoro:force-run Tests on submitted change and removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Sep 11, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 11, 2023
@gbaned gbaned removed the ready to pull PR ready for merge process label Sep 12, 2023
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Sep 12, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 12, 2023
@mihaimaruseac
Copy link
Copy Markdown
Contributor

mihaimaruseac commented Sep 13, 2023

Import didn't affect any internal file

This looks strange. Might be an infra issue or the files has moved?

@johnnkp johnnkp closed this Sep 14, 2023
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gbaned gbaned gbaned approved these changes

+1 more reviewer

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gbaned gbaned

Labels

size:XS CL Change Size: Extra Small

Projects

PR Queue
Status: Closed/Rejected

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@johnnkp @mihaimaruseac @gbaned @d0k @kokoro-team