[PluggableDevice] Kernel C API enhancement for retrieving attributes #44017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
annarev
reviewed
Oct 18, 2020
annarev
reviewed
Nov 3, 2020
annarev
approved these changes
Nov 5, 2020
Contributor
|
Looks good to me. I added API review label so that API owners can take a look as well |
Contributor
|
@jzhoulon Can you please resolve conflicts? Thanks! |
Contributor
Author
guptapriya
reviewed
Dec 2, 2020
| // | ||
| // If the attribute could not be found or could not be interpreted as | ||
| // bool, *status is populated with an error. | ||
| TF_CAPI_EXPORT extern void TF_OpKernelConstruction_GetAttrString( |
Contributor
There was a problem hiding this comment.
So should the type of val be char* val instead?
annarev
approved these changes
Dec 5, 2020
guptapriya
approved these changes
Dec 7, 2020
Contributor
guptapriya
left a comment
There was a problem hiding this comment.
for @tensorflow/api-owners
annarev
reviewed
Dec 8, 2020
tensorflow/c/kernels_test.cc
Outdated
|
|
||
| // Helper macros for the TF_OpKernelConstruction_GetAttr* tests. | ||
| #define EXPECT_TF_SIZE(attr_name, expected_list_size, expected_total_size) \ | ||
| \ |
Contributor
There was a problem hiding this comment.
Remove this line. It just contains \
annarev
approved these changes
Dec 8, 2020
annarev
approved these changes
Dec 8, 2020
copybara-service bot
pushed a commit
that referenced
this pull request
Dec 10, 2020
…ieving attributes PiperOrigin-RevId: 346844467 Change-Id: I9d2121c3ea2402df51879852d0bade21577b3d9b
copybara-service bot
pushed a commit
that referenced
this pull request
Dec 11, 2020
…el_c_api PiperOrigin-RevId: 347042144 Change-Id: I05c7587c7a491199f8ba24109eaf4f6d1bc83c72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more attribution C API for pluggable device kernels implementation.