Fix negative axis issue with ragged tensor and reduce_sum#27699
Merged
tensorflow-copybara merged 2 commits intotensorflow:masterfrom Apr 18, 2019
Merged
Fix negative axis issue with ragged tensor and reduce_sum#27699tensorflow-copybara merged 2 commits intotensorflow:masterfrom
tensorflow-copybara merged 2 commits intotensorflow:masterfrom
Conversation
This fix tries to address the issue raised in 27497 where `tf.reduce_sum` with multiple negative axes and ragged tensor does not produce correct result. The issue is that during reduce op, ragged tensor will reduce one axis at a time. However, for negative axis, sort result is reversed so order is different. This fix convert to positive before the sort to make sure the order. This fix fixes 27497. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
edloper
approved these changes
Apr 10, 2019
alextp
approved these changes
Apr 17, 2019
Contributor
|
@yongtang can you please check build failures |
tensorflow-copybara
pushed a commit
that referenced
this pull request
Apr 18, 2019
PiperOrigin-RevId: 244173513
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix tries to address the issue raised in #27497 where
tf.reduce_sumwith multiple negative axes and ragged tensor does not produce correct result.The issue is that during reduce op, ragged tensor will reduce one axis at a time. However, for negative axis, sort result is reversed so order is different.
This fix convert to positive before the sort to make sure the order.
This fix fixes #27497.
Signed-off-by: Yong Tang yong.tang.github@outlook.com