This repository was archived by the owner on Jun 3, 2020. It is now read-only.
Merged
Conversation
- added a new message type - PubKeyMsg with actual key material needs some further thinking; as prost does not support structs without fields
- encoding of PubKeyMsg with actual ed25519 key works
liamsi
added a commit
to liamsi/prost
that referenced
this pull request
Jul 18, 2018
- currently only (scalar) bytes work (used in tendermint/tmkms#35)
- update to latest prost-fork
liamsi
added a commit
to liamsi/prost
that referenced
this pull request
Jul 24, 2018
- necessary for tendermint/tmkms#35 to work - no other (scalar) types are currently supported (only bytes)
Contributor
|
I think the name of this pile should be |
tarcieri
approved these changes
Jul 24, 2018
alessio
pushed a commit
that referenced
this pull request
May 15, 2020
Upgrade to tendermint-rs v0.12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #34 & ready for review: The changes here are mostly just tests and the actual changes were done in the prost fork (will move it to amino_rs soon and update the dependency in Cargo.toml afterwards).
Also, I've added an
impl Intofor the Signatory types as planned (and approved by Tony) here: #34 (comment)PTAL @zmanian
resolves #34
related #38