Add an option to create MemDB iterators with no Mutex for the CacheKVStore#187
Merged
tac0turtle merged 2 commits intotendermint:release/0.6.xfrom Oct 10, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## release/0.6.x #187 +/- ##
=================================================
- Coverage 68.78% 68.58% -0.20%
=================================================
Files 27 27
Lines 1448 1458 +10
=================================================
+ Hits 996 1000 +4
- Misses 377 383 +6
Partials 75 75
|
tac0turtle
approved these changes
Sep 16, 2021
Contributor
tac0turtle
left a comment
There was a problem hiding this comment.
Can you add a changelog entry
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Contributor
Author
|
Can someone get the workflows to run plz? |
Contributor
|
sorry, all looks goog |
creachadair
pushed a commit
that referenced
this pull request
Nov 9, 2021
…Store (#187) * Add an option to create MemDB iterators with no Mutex for the CacheKVStore * Update changelog
creachadair
pushed a commit
that referenced
this pull request
Nov 15, 2021
Revert the breaking API and package structure changes on master, and prepare to tag a new release compatible with the previous v0.6.4 so that normal upgrades with go get will function correctly. The API changes in tag v0.6.5 have been preserved in the new package-reorg branch, so that any existing dependents will continue to work. Other changes since v0.6.4, including config file changes and CI updates, are maintained on the trunk. This also folds in the merge commit from #187. Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is what we should be using in the SDK for the memDB CacheKVStore invocation there, to get the same guarantees around iterator closing as is present now. (Also this is just faster)
After this, I'll submit a PR that should significantly improve performance of Next operation. (Removes lots of channel overhead)