node: wire up logger to mempool reactor#9885
Merged
thanethomson merged 1 commit intomainfrom Dec 15, 2022
Merged
Conversation
25 tasks
thanethomson
approved these changes
Dec 15, 2022
mergify bot
pushed a commit
that referenced
this pull request
Dec 15, 2022
(cherry picked from commit 1a5d5ed) # Conflicts: # node/setup.go
mergify bot
pushed a commit
that referenced
this pull request
Dec 15, 2022
(cherry picked from commit 1a5d5ed) # Conflicts: # node/setup.go
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems as if the logger was never wired up to the mempool reactor so logs weren't being published by that reactor.
This PR wires it up correctly. I've validated this by running the e2e tests afterwards and checking that the logs actually publish mempool reactor info.
This should also be backported to v0.34.x