workflow: correct the name for the e2e app in the workflow#9850
Merged
williambanfield merged 1 commit intomainfrom Dec 8, 2022
Merged
workflow: correct the name for the e2e app in the workflow#9850williambanfield merged 1 commit intomainfrom
williambanfield merged 1 commit intomainfrom
Conversation
thanethomson
approved these changes
Dec 8, 2022
mergify bot
pushed a commit
that referenced
this pull request
Dec 8, 2022
(cherry picked from commit 365af06)
mergify bot
pushed a commit
that referenced
this pull request
Dec 8, 2022
(cherry picked from commit 365af06)
williambanfield
added a commit
that referenced
this pull request
Dec 8, 2022
williambanfield
added a commit
that referenced
this pull request
Dec 8, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docker image was mistakenly named
testapp, whereas the correct name ise2e-node. This is the name used by the docker-compose file referenced in the e2e tests:tendermint/test/e2e/pkg/infra/docker/docker.go
Line 60 in 3324f49
PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed