Skip to content

fixes abci-cli console help#9821

Merged
lasarojc merged 3 commits intomainfrom
lasarojc/code/fix_abci_cli_help
Dec 4, 2022
Merged

fixes abci-cli console help#9821
lasarojc merged 3 commits intomainfrom
lasarojc/code/fix_abci_cli_help

Conversation

@lasarojc
Copy link
Contributor

@lasarojc lasarojc commented Dec 2, 2022 •
edited
Loading

Help from abci-cli console didn't show prepare and process proposal as subcommands.
This PR fixes the issue.

PR checklist

  • Tests written/updated, or no tests needed
  • CHANGELOG_PENDING.md updated, or no changelog entry needed
  • Updated relevant documentation (docs/) and code comments, or no
    documentation updates needed

@lasarojc lasarojc added the S:backport-to-v0.37.x Tell mergify to backport the PR to v0.37.x label Dec 2, 2022
@lasarojc lasarojc self-assigned this Dec 2, 2022
@lasarojc lasarojc marked this pull request as ready for review December 2, 2022 17:10
@lasarojc lasarojc requested a review from ebuchman as a code owner December 2, 2022 17:10
@lasarojc lasarojc requested a review from a team December 2, 2022 17:10
@lasarojc lasarojc requested a review from adizere as a code owner December 2, 2022 17:10
@lasarojc lasarojc merged commit c3302b0 into main Dec 4, 2022
@lasarojc lasarojc deleted the lasarojc/code/fix_abci_cli_help branch December 4, 2022 11:15
mergify bot pushed a commit that referenced this pull request Dec 4, 2022
@lasarojc @mergify
fixes abci-cli console help (#9821)
5db685e 
* adds prepare and process proposal commands to console help

* comment typo fix

(cherry picked from commit c3302b0)
@mergify mergify bot mentioned this pull request Dec 4, 2022
Merged
lasarojc added a commit that referenced this pull request Dec 5, 2022
@mergify @lasarojc
fixes abci-cli console help (#9821) (#9833)
82c83d9 
* adds prepare and process proposal commands to console help

* comment typo fix

(cherry picked from commit c3302b0)

Co-authored-by: Lasaro Camargos <lasaro@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebuchman ebuchman Awaiting requested review from ebuchman

@adizere adizere Awaiting requested review from adizere

1 more reviewer

@thanethomson thanethomson thanethomson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lasarojc lasarojc

Labels

S:backport-to-v0.37.x Tell mergify to backport the PR to v0.37.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lasarojc @thanethomson