Conversation
thanethomson
approved these changes
Nov 10, 2022
Contributor
thanethomson
left a comment
There was a problem hiding this comment.
Seems reasonable to me. Please add a changelog and upgrading entry though.
This was referenced Jun 22, 2023
Closed
firelizzard18
pushed a commit
to AccumulateNetwork/tendermint
that referenced
this pull request
Nov 24, 2023
…ermint#1109) (tendermint#1121) * Revert "config: add bootstrap peers (tendermint#9680)" (tendermint#1109) * Revert "config: add bootstrap peers (tendermint#9680)" This reverts commit f12588a. * docs/p2p: bootstrap_peers config flag removed (cherry picked from commit 2d3ee28) # Conflicts: # UPGRADING.md # config/toml.go # docs/core/configuration.md * Solving merging conflicts when backporting tendermint#1109 --------- Co-authored-by: Daniel <daniel.cason@informal.systems>
firelizzard18
pushed a commit
to AccumulateNetwork/tendermint
that referenced
this pull request
Feb 1, 2024
* Revert "config: add bootstrap peers (tendermint#9680)" This reverts commit f12588a. * docs/p2p: bootstrap_peers config flag removed
firelizzard18
pushed a commit
to AccumulateNetwork/tendermint
that referenced
this pull request
Feb 1, 2024
…endermint#1010) * Move senders from txs to txSenders * Move resCbFirstTime to globalCb * Fix typo * Remove callback argument from CheckTx * Fix lint * make mocks * lock isSender * Change sync.Map for map with lock; add test * fix lint * comments * move senders to reactor and add txsRemoved channel * Record sender only on valid txs * fix MConnection panicked * notifyTxRemoved when removeAllTxs * Add TxsRemoved and EnableTxsRemoved to interface * Increase channel buffer size * forgot emptyMempool * Change Mempool interface * Revert "Change Mempool interface" This reverts commit d3468a12843b11269a180c9f889f1ec79c55b1d3. * Simplify if/else * Channel buffer size * notify txRemoved even when txKey is not in txsMap * Remove redundant update to map * add callback for removing txs * Add tests * Use Mutex intead of RWMutex * Fix TestMempoolNoCacheOverflow * Fix lint * Fix TestMempoolTxConcurrentWithCommit * Fix TestReactorConcurrency * Comment * Remove references to implemenation details (cache) * Rename removeTxOnReactor * Comment * Rename removeFromCache * Comment * Remove test line forgotten in tendermint#934. * Comment * revert mempool test size * ci: Trigger workflows on merge group (tendermint#1118) Signed-off-by: Thane Thomson <connect@thanethomson.com> * Revert "config: add bootstrap peers (tendermint#9680)" (tendermint#1109) * Revert "config: add bootstrap peers (tendermint#9680)" This reverts commit f12588a. * docs/p2p: bootstrap_peers config flag removed * node: Revert removal of public reactor accessors (tendermint#1120) * Revert "Remove unused code (tendermint#286)" This reverts commit a2d9915. Signed-off-by: Thane Thomson <connect@thanethomson.com> * node: Remove access to consensus state Consensus state should only ever be accessible via the consensus reactor. Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add changelog entry Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix mistake in changelog entry Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Disable CodeQL check in merge queues (tendermint#1123) Signed-off-by: Thane Thomson <connect@thanethomson.com> * p2p: Remove UPnP functionality (tendermint#1114) * Remove UPnP functionality Signed-off-by: Thane Thomson <connect@thanethomson.com> * Update documentation and specs to reflect UPnP removal Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add changelog entry Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> * ADR 107: Rename proto versions to pre-v1 betas (tendermint#1110) * ADR 107: Rename proto versions to pre-v1 betas * ADR 107: fix hyperlinks to ADR 103 * ADR 107: authorship of the revision Co-authored-by: Thane Thomson <connect@thanethomson.com> * ADR 107: change status to Accepted --------- Co-authored-by: Thane Thomson <connect@thanethomson.com> * RFC 104: Internal messaging using the actor model (tendermint#1092) * Add first draft Signed-off-by: Thane Thomson <connect@thanethomson.com> * Expand comment on actor receive method Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix grammar Signed-off-by: Thane Thomson <connect@thanethomson.com> * Emphasize/clarify conclusions Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> * build(deps): Bump github.com/bufbuild/buf from 1.23.1 to 1.24.0 (tendermint#1131) Bumps [github.com/bufbuild/buf](https://github.com/bufbuild/buf) from 1.23.1 to 1.24.0. - [Release notes](https://github.com/bufbuild/buf/releases) - [Changelog](https://github.com/bufbuild/buf/blob/main/CHANGELOG.md) - [Commits](bufbuild/buf@v1.23.1...v1.24.0) --- updated-dependencies: - dependency-name: github.com/bufbuild/buf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): Bump github.com/vektra/mockery/v2 from 2.31.1 to 2.32.0 (tendermint#1132) Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery) from 2.31.1 to 2.32.0. - [Release notes](https://github.com/vektra/mockery/releases) - [Changelog](https://github.com/vektra/mockery/blob/master/docs/changelog.md) - [Commits](vektra/mockery@v2.31.1...v2.32.0) --- updated-dependencies: - dependency-name: github.com/vektra/mockery/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): Bump docker/setup-buildx-action from 2.9.0 to 2.9.1 (tendermint#1133) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2.9.0 to 2.9.1. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v2.9.0...v2.9.1) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): Bump bufbuild/buf-setup-action from 1.23.1 to 1.24.0 (tendermint#1134) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.23.1 to 1.24.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.23.1...v1.24.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * spec: Add mempool specification in English and Quint (tendermint#997) * add mempool English and Quint specifications * some changes * Update spec/mempool/mempool.md Co-authored-by: Lasaro <lasaro@gmail.com> * Update spec/mempool/mempool.md Co-authored-by: Lasaro <lasaro@gmail.com> * small change to the text * add changelog entry * some minor fixes --------- Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com> Co-authored-by: Lasaro <lasaro@gmail.com> * Add NewRandomTxs * Fix TestReactorTxSendersMultiNode * Fix TestDontExhaustMaxActiveIDs * Fix unused parameter * Add changelog * Update UPGRADING.md * Remove unused link in doc --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Daniel <daniel.cason@informal.systems> Co-authored-by: Mikhail Zabaluev <mikhail.zabaluev@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pierre Sutra <0track@gmail.com> Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com> Co-authored-by: Lasaro <lasaro@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new config field: bootstrap peers, a comma separated string of addresses to be added to the addressbook upon node startup. Currently, some node operators misuse persistent peers as a way of adding addresses to dial. Persistent peers has the characteristic of always redialing that peer to keep a consistent connection (designed for sentries) which might not be what node operators intended for.
This feature is ported across from v0.35.x
PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed