e2e: configurable IP addresses for e2e testnet generator#9592
Merged
williambanfield merged 18 commits intomainfrom Oct 25, 2022
Merged
e2e: configurable IP addresses for e2e testnet generator#9592williambanfield merged 18 commits intomainfrom
williambanfield merged 18 commits intomainfrom
Conversation
sergio-mena
reviewed
Oct 21, 2022
sergio-mena
approved these changes
Oct 24, 2022
Contributor
sergio-mena
left a comment
There was a problem hiding this comment.
Making the most of the Wifi I can find :-D
williambanfield
added a commit
that referenced
this pull request
Oct 25, 2022
williambanfield
added a commit
that referenced
this pull request
Oct 25, 2022
This was referenced Oct 25, 2022
williambanfield
added a commit
that referenced
this pull request
Oct 31, 2022
) (#9624) Co-authored-by: Thane Thomson <connect@thanethomson.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the e2e
Setuplogic and all other parts of the runner that use its code to accept list of IP addresses from already existing infrastructure to be used when generating the testnet configuration.The change adds two new flags
--infrastructure-type: The type of the backing infrastructure, either 'digital-ocean' or docker--infrastructure-data: The path to a file containing information on already existing infrastructure.This new
infrastructure-dataflag selects the path to a json file whose contents can be deserialized into the newInfrastructureDatatype. This type contains a map of node name to IP address. The map is then used when constructing the testnet. Instead of generating a new IP address for each Tendermint node, the code reaches into the map to determine what the IP address is. A docker variant of this is also defined that, instead of reading data from disk, generates a new set of IP addresses per the already existing logic for IP generation.This change also adds a new
infra.Providerinterface type. TheProvidercurrently only has one method,Setupthat sets up any configuration files for the specific infrastructure being used. Fordocker, this method generates thedocker-compose.yamlfile. Fordigital-ocean, the method is a Noop. This type borrows from the TestnetInfra type created for the runner in the now defunctv0.36.xcode as part of #8754. The hope would be to gradually add more functionality to theinfra.Provideruntil it is much closer to what is implemented previously.Closes: #9587
PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed