backport: rewrite the WaitForOneEvent helper for rpc/client (#7986)#9550
Merged
sergio-mena merged 1 commit intotendermint:feature/adr075-backportfrom Nov 3, 2022
Merged
Conversation
Update usage in tests.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Author
|
@cmwaters @sergio-mena May I know if any change is needed here? |
cmwaters
approved these changes
Oct 25, 2022
| if err != nil { | ||
| return err | ||
| } else if len(rsp.Items) == 0 { | ||
| continue // continue polling until ctx expires |
Contributor
There was a problem hiding this comment.
Not sure if it would be better to wait between polling but I guess it's fine
Author
There was a problem hiding this comment.
Actually WaitForOneEvent keep continue since err set to nil when timeout.
Author
There was a problem hiding this comment.
Do we need further change? Since rpc doesn't report a timeout as a request failure and this function seems only use for test.
Contributor
There was a problem hiding this comment.
No I think it's okay. As you said, this is just used for testing
sergio-mena
approved these changes
Nov 3, 2022
mmsqe
added a commit
to mmsqe/tendermint
that referenced
this pull request
Dec 9, 2022
…dermint#9550) Update usage in tests. Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
mmsqe
added a commit
to mmsqe/tendermint
that referenced
this pull request
Dec 9, 2022
…dermint#9550) Update usage in tests. Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the full description, see #7986
PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed