backport: hook up eventlog and eventlog metrics (#7981)#9510
Merged
sergio-mena merged 3 commits intotendermint:feature/adr075-backportfrom Oct 6, 2022
Merged
Conversation
cmwaters
reviewed
Oct 5, 2022
node/node.go
Outdated
| proxy.PrometheusMetrics(config.Namespace, "chain_id", chainID) | ||
| } | ||
| return cs.NopMetrics(), p2p.NopMetrics(), mempl.NopMetrics(), sm.NopMetrics(), proxy.NopMetrics() | ||
| return cs.NopMetrics(), nil, p2p.NopMetrics(), mempl.NopMetrics(), sm.NopMetrics(), proxy.NopMetrics() |
Contributor
There was a problem hiding this comment.
Is there not a eventlog.NopMetrics()? I think this will panic if we leave it as nil
Author
There was a problem hiding this comment.
We have check nil here, but I added NopMetrics to be consistent, same default value.
sergio-mena
reviewed
Oct 5, 2022
internal/eventlog/metrics.go
Outdated
| } | ||
| } | ||
|
|
||
| func NopMetrics() *Metrics { |
Contributor
There was a problem hiding this comment.
The other NopMetrics seem to be generated code.
Is there a reason for this code to be manual?
Author
There was a problem hiding this comment.
Good catch, since other metrics generated after evetlog get introduced.
sergio-mena
approved these changes
Oct 6, 2022
mmsqe
added a commit
to mmsqe/tendermint
that referenced
this pull request
Dec 9, 2022
…ndermint#9510) * node: hook up eventlog and eventlog metrics (tendermint#7981) * align no metrics for event log * make use of metricsgen Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
mmsqe
added a commit
to mmsqe/tendermint
that referenced
this pull request
Dec 9, 2022
…ndermint#9510) * node: hook up eventlog and eventlog metrics (tendermint#7981) * align no metrics for event log * make use of metricsgen Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the full description, see #7981
PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed