Merged
Conversation
Signed-off-by: Thane Thomson <connect@thanethomson.com>
1f82dab to
e25d40f
Compare
Contributor
|
Sorry, I missed suggesting to take the opp to set Tendermint version as well. Let me open a quick PR for that |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After talking with the council, there's agreement that Tendermint v0.37 should release its ABCI protocol version as "1.0.0", and when vote extensions land it should be "2.0.0".
To expand on the reasoning: previously @sergio-mena asked whether it makes sense to have a "1.0" version of a protocol in a "0.x" implementation. Originally it didn't make sense to me, but after thinking about it some more it actually does, because the specifications will ultimately end up driving the Tendermint Core versions. Once we have all of the various protocols specified (and versioned), and we know that Tendermint Core implements all of those specifications, then we can cut a "1.0" release of the Tendermint Core implementation (my understanding of @xla's idea).
And on top of that, version numbers are cheap 🙂
This PR can be automatically backported to
v0.37.xonce #9338 lands.PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed