Skip to content

ci: Prepare for v0.37 release branch#9338

Merged
thanethomson merged 3 commits intomainfrom
thane/ci-v0.37
Aug 31, 2022
Merged

ci: Prepare for v0.37 release branch#9338
thanethomson merged 3 commits intomainfrom
thane/ci-v0.37

Conversation

@thanethomson
Copy link
Contributor

Depends on #9337.

Prepare the CI to handle the v0.37 development processes, as per our release guidelines.


PR checklist

  • Tests written/updated, or no tests needed
  • CHANGELOG_PENDING.md updated, or no changelog entry needed
  • Updated relevant documentation (docs/) and code comments, or no
    documentation updates needed

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson requested a review from ebuchman as a code owner August 30, 2022 19:45
@thanethomson thanethomson requested a review from a team August 30, 2022 19:45
@thanethomson thanethomson mentioned this pull request Aug 30, 2022
3 tasks
@@ -0,0 +1,104 @@
# Runs randomly generated E2E testnets nightly on the v0.37.x branch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you took .github/workflows/e2e-nightly-34x.yml and mechanically adapted it.
Let me know if you did otherwise.

Copy link
Contributor Author

@thanethomson thanethomson Aug 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually a combination of .github/workflows/e2e-nightly-{main,34x}.yml, adapted for v0.37.x. The main E2E tests run more testnet groups.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, checking out your branch and melding the files.

Copy link
Contributor

@sergio-mena sergio-mena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! :-)

@thanethomson thanethomson merged commit bdf0217 into main Aug 31, 2022
@thanethomson thanethomson deleted the thane/ci-v0.37 branch August 31, 2022 02:53
Comment on lines +30 to +34
- name: Capture git repo info
id: git-info
run: |
echo "::set-output name=branch::`git branch --show-current`"
echo "::set-output name=commit::`git rev-parse HEAD`"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find this part in yml for main, intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This is one of the parts that need to be taken from the 34x file to facilitate our Slack failure notifications.

With main it's easy because the latest commit hash and branch details are provided by GitHub through environment variables when the nightly E2E tests run.

But because we manually check out the v0.34.x / v0.37.x branches, we need to store this information in output variables during the test execution job so we can use them later during the notification jobs. If we don't do this, and we rely on those environment variables, we just get main and the latest commit hash on main, because that's where the nightly run was triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants