Update rpc client header by samricotta · Pull Request #9276 · tendermint/tendermint

samricotta · 2022-08-17T07:10:59Z

Moving the changes from issue #7270 into main. This introduces header and header_by_hash queries to the RPC client. This is useful for Evmos JSON-RPC to avoid querying the block endpoint for the eth_header and eth_header_by_hash JSON-RPC endpoints

Note: This is part of the ABCI++ Prepare/Process Proposal Release Plan #9091

cmwaters · 2022-08-17T15:11:08Z

CHANGELOG_PENDING.md


 ### IMPROVEMENTS

+[abci/rpc] \#9276 `header` and `header_by_hash` queries to the RPC client


Suggested change

[abci/rpc] \#9276 `header` and `header_by_hash` queries to the RPC client

[rpc] \#9276 Add `header` and `header_by_hash` queries to the RPC layer

cmwaters · 2022-08-17T15:13:40Z

rpc/openapi/openapi.yaml

+          content:
+            application/json:
+              schema:
+                $ref: "#/components/schemas/HeaderResponse"


Suggested change

$ref: "#/components/schemas/HeaderResponse"

$ref: "#/components/schemas/BlockHeader"

cmwaters · 2022-08-17T15:13:48Z

rpc/openapi/openapi.yaml

+          content:
+            application/json:
+              schema:
+                $ref: "#/components/schemas/HeaderResponse"


Suggested change

$ref: "#/components/schemas/HeaderResponse"

$ref: "#/components/schemas/BlockHeader"

cmwaters · 2022-08-17T15:14:16Z

store/store.go


+// LoadBlockMetaByHash returns the blockmeta who's header corresponds to the given
+// hash. If none is found, returns nil.
+func (bs *BlockStore) LoadBlockMetaByHash(hash []byte) *types.BlockMeta {


Want to add a test for this as well? (or add it in an existing test?)

williambanfield

Looks good, would echo Callum's request for a test of LoadBlockMetaByHash

github-actions · 2022-08-28T00:22:22Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

…header

sergio-mena · 2022-08-31T11:58:17Z

CHANGELOG_PENDING.md

+[rpc] \#9276 `header` and `header_by_hash` queries to the RPC client
+


Is this supposed to be here?

sergio-mena · 2022-08-31T11:58:28Z

CHANGELOG_PENDING.md


 ### IMPROVEMENTS

+- [rpc] \#9276 `header` and `header_by_hash` queries to the RPC client


Suggested change

- [rpc] \#9276 `header` and `header_by_hash` queries to the RPC client

- [rpc] \#9276 Added `header` and `header_by_hash` queries to the RPC client

sergio-mena · 2022-08-31T12:18:20Z

rpc/core/blocks.go


+// Header gets block header at a given height.
+// If no height is provided, it will fetch the latest header.
+// More: https://docs.tendermint.com/master/rpc/#/Info/header


The link contains master, should it be renamed to main?

sergio-mena · 2022-08-31T12:27:37Z

store/store_test.go

+	baseBlock := bs.LoadBlockMetaByHash(block.Hash())
+	assert.EqualValues(t, block.Header.Height, baseBlock.Header.Height)
+	assert.EqualValues(t, block.Header.LastBlockID, baseBlock.Header.LastBlockID)
+	assert.EqualValues(t, block.Header.ChainID, baseBlock.Header.ChainID)


Can you flip one bit of the hash, repeat the call, and check we now get nil?

sergio-mena

LGTM

* Update rpc client header (cherry picked from commit 2ff11e5)

* Update rpc client header (cherry picked from commit 2ff11e5) Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com>

…x-rc1 * release/v0.37.0-rc1: QA Process report for v0.37.x (and baseline for v0.34.x) (tendermint#9499) (tendermint#9577) Fix TX payload for DO testnets (tendermint#9540) (tendermint#9542) blocksync: retry requests after timeout (backport tendermint#9518) (tendermint#9533) Extend the load report tool to include transactions' hashes (tendermint#9509) (tendermint#9513) build(deps): Bump styfle/cancel-workflow-action from 0.10.0 to 0.10.1 (tendermint#9502) build(deps): Bump actions/stale from 5 to 6 (tendermint#9494) loadtime: add block time to the data point (tendermint#9484) (tendermint#9489) config: Add missing storage section when generating config (tendermint#9483) (tendermint#9487) Sync Vote.Verify() in spec with implementation (tendermint#9466) (tendermint#9476) fix spec (tendermint#9467) (tendermint#9469) metrics: fix panic because of absent prometheus label (tendermint#9455) (tendermint#9474) Ensure Dockerfile stages use consistent Go version (backport tendermint#9462) (tendermint#9472) build(deps): Bump slackapi/slack-github-action from 1.21.0 to 1.22.0 (tendermint#9432) build(deps): Bump bufbuild/buf-setup-action from 1.7.0 to 1.8.0 (tendermint#9453) state: restore previous error message (tendermint#9435) (tendermint#9440) build(deps): Bump gonum.org/v1/gonum from 0.11.0 to 0.12.0 (tendermint#9411) docs: Update ADRs for v0.37 (tendermint#9399) (tendermint#9418) build(deps): Bump github.com/spf13/viper from 1.12.0 to 1.13.0 (tendermint#9410) build(deps): Bump github.com/lib/pq from 1.10.6 to 1.10.7 (tendermint#9409) feat: support HTTPS inside websocket (tendermint#9416) (tendermint#9422) Removed unused param (tendermint#9394) test: generate uuid on startup for load tool (tendermint#9383) (tendermint#9392) add redirect links (tendermint#9385) (tendermint#9389) refactor: migrate to cosmos/gogoproto (backport tendermint#9356) (tendermint#9381) cmd: print all versions of tendermint and its sub protocols (tendermint#9329) (tendermint#9386) Add missing changes changelog files (backport tendermint#9376) (tendermint#9382) add separated runs by UUID (backport tendermint#9367) (tendermint#9379) spec: abci++ cleanup for v0.37 (backport tendermint#9288) (tendermint#9374) ci: Remove "(WARNING: BETA SOFTWARE)" tagline from all upcoming releases (tendermint#9371) (tendermint#9372) Update rpc client header (tendermint#9276) (tendermint#9349) ci: Pre-release workflows (backport tendermint#9366) (tendermint#9368) test: add the loadtime report tool (tendermint#9351) (tendermint#9364) Update Tendermint version to v0.37.0 (tendermint#9354) test: add the loadtime tool (tendermint#9342) (tendermint#9357) # Conflicts: # version/version.go

samricotta added 3 commits August 17, 2022 09:01

Update rpc client header

d47b012

Update openapi.yaml

245e029

mocks

b7c3ab1

samricotta requested a review from ebuchman as a code owner August 17, 2022 07:11

samricotta requested a review from a team August 17, 2022 07:11

samricotta changed the title ~~Rpcheader~~ Update rpc client header Aug 17, 2022

samricotta added 2 commits August 17, 2022 09:22

Update rpc_test.go

f0492fc

Update CHANGELOG_PENDING.md

96e7493

cmwaters reviewed Aug 17, 2022

View reviewed changes

williambanfield reviewed Aug 17, 2022

View reviewed changes

github-actions bot added the stale for use by stalebot label Aug 28, 2022

thanethomson removed the stale for use by stalebot label Aug 30, 2022

samricotta and others added 9 commits August 31, 2022 10:11

Update rpc client header

8fe974c

Update openapi.yaml

848d624

mocks

304ea29

Update rpc_test.go

bf3625c

Update CHANGELOG_PENDING.md

9b22db9

test for load block meta by hash

8195247

Merge branch 'main' into rpcheader

be3d915

Merge branch 'rpcheader' of github.com:tendermint/tendermint into rpc…

8f3ae94

…header

Update store_test.go

c22efdc

sergio-mena reviewed Aug 31, 2022

View reviewed changes

samricotta and others added 4 commits September 1, 2022 10:52

update for review

1aed0a9

Update store_test.go

3c39d52

Merge branch 'main' into rpcheader

b0c56e5

Update openapi.yaml

7cf52d8

sergio-mena approved these changes Sep 1, 2022

View reviewed changes

samricotta self-assigned this Sep 1, 2022

samricotta added the S:backport-to-v0.37.x Tell mergify to backport the PR to v0.37.x label Sep 1, 2022

samricotta merged commit 2ff11e5 into main Sep 1, 2022

samricotta deleted the rpcheader branch September 1, 2022 12:35

mergify bot mentioned this pull request Sep 1, 2022

Update rpc client header (backport #9276) #9349

Merged

mergify bot pushed a commit that referenced this pull request Sep 1, 2022

Update rpc client header (#9276)

ea81e7a

* Update rpc client header (cherry picked from commit 2ff11e5)

lbrown2007 pushed a commit that referenced this pull request Sep 2, 2022

Update rpc client header (#9276)

d4df3c3

* Update rpc client header (cherry picked from commit 2ff11e5)

lbrown2007 pushed a commit that referenced this pull request Sep 3, 2022

Update rpc client header (#9276)

e108bb3

* Update rpc client header (cherry picked from commit 2ff11e5)

thanethomson pushed a commit that referenced this pull request Sep 3, 2022

Update rpc client header (#9276) (#9349)

8b45f29

* Update rpc client header (cherry picked from commit 2ff11e5) Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update rpc client header#9276

Update rpc client header#9276
samricotta merged 18 commits intomainfrom
rpcheader

samricotta commented Aug 17, 2022

Uh oh!

cmwaters Aug 17, 2022

Uh oh!

cmwaters Aug 17, 2022

Uh oh!

cmwaters Aug 17, 2022

Uh oh!

cmwaters Aug 17, 2022

Uh oh!

williambanfield left a comment

Uh oh!

github-actions bot commented Aug 28, 2022

Uh oh!

sergio-mena Aug 31, 2022

Uh oh!

sergio-mena Aug 31, 2022

Uh oh!

sergio-mena Aug 31, 2022

Uh oh!

sergio-mena Aug 31, 2022

Uh oh!

sergio-mena left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants


		### IMPROVEMENTS

		[abci/rpc] \#9276 `header` and `header_by_hash` queries to the RPC client

	[abci/rpc] \#9276 `header` and `header_by_hash` queries to the RPC client
	[rpc] \#9276 Add `header` and `header_by_hash` queries to the RPC layer

	$ref: "#/components/schemas/HeaderResponse"
	$ref: "#/components/schemas/BlockHeader"

		[rpc] \#9276 `header` and `header_by_hash` queries to the RPC client


		### IMPROVEMENTS

		- [rpc] \#9276 `header` and `header_by_hash` queries to the RPC client

	- [rpc] \#9276 `header` and `header_by_hash` queries to the RPC client
	- [rpc] \#9276 Added `header` and `header_by_hash` queries to the RPC client

Conversation

samricotta commented Aug 17, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

williambanfield left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 28, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sergio-mena left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants