Update type annotations in the TLA+ spec of Tendermint for accountability#9263
Merged
Update type annotations in the TLA+ spec of Tendermint for accountability#9263
Conversation
cmwaters
pushed a commit
that referenced
this pull request
Aug 19, 2022
…lity (#9263) * update Apalache type annotations and split evidence into 3 variables * remove the duplicate of AllPrevotes, due to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains an update of type annotations for the TLA+ specification of Tendermint. By using the new type annotations, we make sure that no imprecise record access is possible. For details, see Type System 1.2 of Apalache.
Most of the diff is simple: Just using the new syntax for records and type aliases instead of the old syntax. Since the new type system of Apalache does not let one mix records of different shapes into a single set, we had to partition the state variable
evidenceinto three variables:evidencePropose,evidencePrevote,evidencePrecommit. Alternatively, we could use variants, but that would only make the specification more complex.