config: backport the rename of fastsync to blocksync #9259
config: backport the rename of fastsync to blocksync #9259mergify[bot] merged 15 commits intomainfrom
Conversation
|
The config.toml is breaking right? say I had "v1" selected in v0.34. v0.37 won't correctly read it and think that it's not set and thus use the default ("v0"). I'm not sure how much of a problem this is as we've deprecated all the other options. In v0.37 we're essentially forcing everyone to use "v0". |
|
It will read it correctly, it will just error: Line 900 in 2f9ea4a EDIT: I see what you're saying: the name of the toml table changed to |
|
Yeah this would be something that an automated migration set up would be able to handle. I think a warning in the logs upon start up makes sense |
5e90e7a to
2fc4b8a
Compare
This is largely a cherry pick of #6755 with some additional fixups added where detected. This change moves the blockchain package to a package called blocksync. Additionally, it renames the relevant uses of the term `fastsync` to `blocksync`. closes: #9227 #### PR checklist - [ ] Tests written/updated, or no tests needed - [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed - [x] Updated relevant documentation (`docs/`) and code comments, or no documentation updates needed
This is largely a cherry pick of #6755 with some additional fixups added where detected.
This change moves the blockchain package to a package called blocksync. Additionally, it renames the relevant uses of the term
fastsynctoblocksync.closes: #9227
PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed