ABCI types.proto. Handle remaining discrepancies#9224
Merged
sergio-mena merged 3 commits intofeature/abci++pppfrom Aug 12, 2022
Merged
ABCI types.proto. Handle remaining discrepancies#9224sergio-mena merged 3 commits intofeature/abci++pppfrom
types.proto. Handle remaining discrepancies#9224sergio-mena merged 3 commits intofeature/abci++pppfrom
Conversation
- add `AbciVersion` RequestInfo Closes: #2804
williambanfield
approved these changes
Aug 11, 2022
cmwaters
reviewed
Aug 12, 2022
| string version = 1; | ||
| uint64 block_version = 2; | ||
| uint64 p2p_version = 3; | ||
| string abci_version = 4; |
Contributor
There was a problem hiding this comment.
Does this need to be a string? can't we use a uint64 like we do with block_version and p2p_version?
Contributor
Author
There was a problem hiding this comment.
This field is populated from ABCISemVer, which uses semantic versioning. ABCISemVer is defined this way also in v0.34.x and probably in earlier releases.
So I am for not changing the versioning scheme.
However, I'll take the opp for bumping it now (to signal inclusion of PrepareProposal and ProcessProposal)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9221
Out of the list of discrepancies on type.proto for abci (see #9221):
ConsensusParamsandBlockParamswhere it is. Several reasons, but the two main ones: (1) this is v0.34, it works, and this change is not needed to deliver Prepare/ProcessProposal, and (2) the commit that changed this in v0.3[56].x doesn't contain any obvious logic change or improvement that justifies itRequestInfohas been cherry-picked. Reasons:EventAttributefrom bytes to string. Findings in git history don't justify this change. If need it can be done later, not gating Prepare/ProcessProposalResponseCheckTx. Likewise we won't do this change as it is non-trivial, and it is not gating for releasing Prepare/ProcessProposal(on PR checklist below: only partially done, the changes are comming from the cherry-picked commit. It will be fully handled at the time the feature branch is merged with
main, which will happen soon)PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed