ci: Update nightly E2E notifications#9177
Merged
thanethomson merged 3 commits intomainfrom Aug 6, 2022
Merged
Conversation
Signed-off-by: Thane Thomson <connect@thanethomson.com>
tychoish
approved these changes
Aug 5, 2022
| @@ -47,12 +47,27 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - name: Notify Slack on failure | |||
Contributor
There was a problem hiding this comment.
Should we add a 'success' block to this workflow? Or, maybe it's present and I'm not seeing it?
Contributor
Author
There was a problem hiding this comment.
Oh there wasn't a success block for v0.34. I can easily add one though.
Contributor
Author
There was a problem hiding this comment.
I've added one now 👍
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
3 tasks
samricotta
pushed a commit
that referenced
this pull request
Aug 9, 2022
samricotta
pushed a commit
that referenced
this pull request
Aug 12, 2022
samricotta
pushed a commit
that referenced
this pull request
Aug 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates our nightly E2E notifications to use the incoming webhook approach, targeting our engineering team channel.