Merged
Conversation
mark-rushakoff
approved these changes
Aug 1, 2022
Contributor
mark-rushakoff
left a comment
There was a problem hiding this comment.
I'm not sure why the linter started complaining about these existing lines -- maybe the new indirect entries in go.mod updated a version of a linter unexpectedly?
+1 to moving to go1.18 anyway.
Contributor
Author
Seems like a lot of the linting stuff was deprecated in go1.18 |
Contributor
|
We are on v1.47.2 of golangci-lint, and v1.47.3 was released two hours ago, including golangci/golangci-lint#3001 to "remove some go1.18 limitations". Shouldn't hurt to update to that newer patch release. |
.golangci.yml
Outdated
| enable: | ||
| - asciicheck | ||
| - bodyclose | ||
| # - bodyclose // to be fixed by golangci-lint |
Contributor
There was a problem hiding this comment.
bodyclose support is supposed to be re-enabled as part of golangci-lint v1.47.3, according to golangci/golangci-lint#3001.
mark-rushakoff
approved these changes
Aug 1, 2022
Contributor
mark-rushakoff
left a comment
There was a problem hiding this comment.
New updates still LGTM.
samricotta
pushed a commit
that referenced
this pull request
Aug 1, 2022
samricotta
pushed a commit
that referenced
this pull request
Aug 1, 2022
samricotta
pushed a commit
that referenced
this pull request
Aug 1, 2022
cmwaters
added a commit
that referenced
this pull request
Aug 8, 2022
samricotta
pushed a commit
that referenced
this pull request
Aug 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.